lcov: filter depends from coverage reports #17647

pull nijynot wants to merge 2 commits into bitcoin:master from nijynot:fix/lcov-depends changing 1 files +11 −3
  1. nijynot commented at 1:07 AM on December 2, 2019: contributor

    If you build the binaries with the depends folder and then generate coverage reports with make cov, depends will be included in the coverage reports. Coverage of the dependencies are not that interesting and should be filtered.

  2. fanquake added the label Build system on Dec 2, 2019
  3. DrahtBot commented at 2:44 AM on December 2, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #17398 (build: Update leveldb to 1.22+ by laanwj)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. in Makefile.am:192 in a6a7c1bb8e outdated 
     188 | @@ -189,7 +189,7 @@ $(BITCOIN_WALLET_BIN): FORCE
 189 |  	$(MAKE) -C src $(@F)
 190 |  
 191 |  if USE_LCOV
 192 | -LCOV_FILTER_PATTERN=-p "/usr/include/" -p "/usr/lib/" -p "src/leveldb/" -p "src/bench/" -p "src/univalue" -p "src/crypto/ctaes" -p "src/secp256k1"
 193 | +LCOV_FILTER_PATTERN=-p "/usr/include/" -p "/usr/lib/" -p "src/leveldb/" -p "src/bench/" -p "src/univalue" -p "src/crypto/ctaes" -p "src/secp256k1" -p "depends"
    MarcoFalke commented at 4:13 PM on December 3, 2019:

    style-nit: Could make this multiline to avoid very long lines?

    nijynot commented at 7:00 PM on December 4, 2019:

    Will fix! :+1:

    laanwj commented at 9:34 AM on December 6, 2019:

    Right, usually the one-per-line approach is preferred for these, not only because long lines are inconvenient but also as it makes it easier to review as well as rebase changes

  5. MarcoFalke approved
  6. MarcoFalke commented at 4:13 PM on December 3, 2019: member

    ACK. Will test

  7. lcov: filter depends from coverage report a5a705b46d
  8. nijynot force-pushed on Dec 6, 2019
  9. nijynot renamed this:
    lcov: filter depends
    lcov: filter depends from coverage reports
    on Dec 6, 2019
  10. nijynot commented at 4:51 PM on December 7, 2019: contributor

    LCOV_FILTER_PATTERN is now multiline.

  11. lcov: filter /usr/lib64 from coverage report f736f6920b
  12. in Makefile.am:194 in a5a705b46d outdated 
     188 | @@ -189,7 +189,15 @@ $(BITCOIN_WALLET_BIN): FORCE
 189 |  	$(MAKE) -C src $(@F)
 190 |  
 191 |  if USE_LCOV
 192 | -LCOV_FILTER_PATTERN=-p "/usr/include/" -p "/usr/lib/" -p "src/leveldb/" -p "src/bench/" -p "src/univalue" -p "src/crypto/ctaes" -p "src/secp256k1"
 193 | +LCOV_FILTER_PATTERN = \
 194 | +	-p "/usr/include/" \
 195 | +	-p "/usr/lib/" \
    MarcoFalke commented at 5:36 PM on December 8, 2019:

    Could you add a commit to also exclude lib64, please. This shows up when compiling with clang-8 for example:

    https://pbs.twimg.com/media/ELKJFh3XsAAM6mJ?format=png&name=medium

    nijynot commented at 11:16 PM on December 8, 2019:

    Done! Guessing that I should squash the commits too?

    laanwj commented at 11:05 AM on December 9, 2019:

    I think it's fine to have these as separate commits, they're not really related

    nijynot commented at 1:32 PM on December 9, 2019:

    Sounds good, will keep it as is! 👌

  13. laanwj commented at 11:06 AM on December 9, 2019: member

    code review ACK f736f6920b160c9e7d7072500ddd0459c5181f86

  14. MarcoFalke commented at 1:38 PM on December 9, 2019: member

    ACK f736f6920b160c9e7d7072500ddd0459c5181f86 🐇

    <details><summary>Show signature and timestamp</summary>

    Signature:

    -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK f736f6920b160c9e7d7072500ddd0459c5181f86 🐇
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUiCUgwAnGb18yCEtCe5OjCrdAEbZi41rVNvSpfSBJuj3Hfd3BQ/ao8LNJSc8vth
/gnublAX7N9eNu0nW8xC/P8YLiNZ2pWRBS/TYc6SBoA7p6moicv95L5yOtmUO7Jf
YEimYpnvqfSX+VnLvjsD0j3wWynJoQMuPRpQoHuNQJphwXyfTKWlMToFUY6H2YKs
G3229G+Kh00kAzaL1EE2nNUUj8SMf1w2UT0xF7nSf4nkRxRVFspK42loJAni6RmV
EOz/wkYk8G2MKfnR91h5+s458njP5JFB/wQIk0+cuX9wx/NMTRaQadKo+UvIt94G
h+utUjG43wCltZHMGH7xTIBM3BKRhuGaa+JYiqmFcbz+HKaWe3MFUc5TVWI7tKJv
TQjKA52U6xRP8mcnjW2Ul6U82RCy1+YtzrppZCcriY1hfcqi4aVnwxojsbJ3I9G9
b+YI2czru7XlCzBh6dFumeBFTU67M7+Rsym/d2MTEn5Mms6/jS04nEkJuCwP4Foe
2eDEEAT0
=QVGe
-----END PGP SIGNATURE-----

    Timestamp of file with hash b372428e288a16e241dced9edf731090d312c52e912c70c55e4fc97fd967002a -

    </details>

  15. MarcoFalke referenced this in commit 1ebf6402fc on Dec 9, 2019
  16. MarcoFalke merged this on Dec 9, 2019
  17. MarcoFalke closed this on Dec 9, 2019
  18. sidhujag referenced this in commit f2c48d458b on Dec 9, 2019
  19. deadalnix referenced this in commit 6a4c5c2794 on Feb 20, 2020
  20. ftrader referenced this in commit 96fae32cc6 on May 19, 2020
  21. sidhujag referenced this in commit 092b3932fb on Nov 10, 2020
  22. knst referenced this in commit 8f14cf263f on May 26, 2022
  23. knst referenced this in commit e5ed553964 on May 27, 2022
  24. knst referenced this in commit f1995b6ef9 on May 30, 2022
  25. UdjinM6 referenced this in commit ab3b4a520a on Jun 3, 2022
  26. DrahtBot locked this on Aug 16, 2022
Contributors
nijynotDrahtBotMarcoFalkelaanwj
Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me