CI: GitHub Action workflow which duplicates AppVeyor job #17697

1. 
   sipsorcery commented at 8:06 pm on December 8, 2019: member

   As discussed in #17594 this PR contains a GitHub Action workflow file that performs the same job as the current Appveyor CI task except for the Python functional tests. For the latter I’ve been unable to get them to execute successfully due to a Unicode error. I’ve tried on and off for a week to get it to work but with no joy.

   It may be that someone more proficient in Python will recognise the error and be able to provide a pointer on how to proceed. I’ve tried some obvious things like changing the Windows console code page.

   To run this job it should just be a matter of clicking on the GitHub Actions tab and enabling workflows. It’s also not required that the file is on the master branch for the job to run. If anyone else wants to run the job they can pull this PR into their own fork and enable Actions (it’s free).

2. fanquake added the label Tests on Dec 8, 2019
3. fanquake added the label Needs Conceptual Review on Dec 8, 2019
4. sipsorcery force-pushed on Dec 8, 2019
5. in .github/workflows/bitcoin.yml:1 in aa3a3c614a outdated

   0@@ -0,0 +1,76 @@
   1+name: bitcoin-ci
   

   ---

   ---

   

   MarcoFalke commented at 2:31 pm on December 9, 2019:

   0name: bitcoin-core-ci
   

   Also, could the file be renamed to just ci.yml to better represent what it does?

6. in .github/workflows/bitcoin.yml:18 in aa3a3c614a outdated

   13+        VCPKG_INSTALL_PATH: "$env:VCPKG_INSTALLATION_ROOT/installed"
   14+        PLATFORM: x64
   15+    steps:
   16+    - uses: actions/checkout@v1
   17+
   18+    - uses: actions/cache@v1
   

   ---

   ---

   

   MarcoFalke commented at 2:33 pm on December 9, 2019:

   The cache is only 400 MB. Is this enough? https://github.com/actions/cache#cache-limits

   ---

   

   sipsorcery commented at 2:57 pm on December 9, 2019:

   It is for the vcpkg packages. It’s not for the Qt binaries. In the case of the latter it’s only taking around 90s to download and extract so the cache isn’t essential. In the case of the former it’s taking around 30 minutes to install the packages so the cache there halves the time of the job,
7. MarcoFalke approved
8. 
   MarcoFalke commented at 2:33 pm on December 9, 2019: member

   ACK. No objections to merge this in the same fashion as the cirrus.yml was merged.
9. 
   MarcoFalke commented at 2:36 pm on December 9, 2019: member

   It’s also not required that the file is on the master branch for the job to run

   Huh, how would it pick the right script to run if there are multiple on different branches or if the script is changed in some commits?

10. 
    sipsorcery commented at 3:04 pm on December 9, 2019: member

    It’s also not required that the file is on the master branch for the job to run

    Huh, how would it pick the right script to run if there are multiple on different branches or if the script is changed in some commits?

    I think it will run them all.

    From my testing as long as the name at the top of the script is different then each .github\workflows\*.yml workflow can be triggered. If the name is the same my guess would be either the master branch or the oldest instance takes priority.

11. Adds GitHub Action workflow which duplicates AppVeyor job. b0b1531737
12. sipsorcery force-pushed on Dec 9, 2019
13. MarcoFalke removed the label Needs Conceptual Review on Dec 9, 2019
14. 
    MarcoFalke commented at 6:01 pm on December 9, 2019: member

    Ok, I think this is good to merge, but enabling the action would maybe need some more testing/discussion, which can happen separate from the code changes.
15. MarcoFalke referenced this in commit fab9d115cd on Dec 11, 2019
16. MarcoFalke merged this on Dec 11, 2019
17. MarcoFalke closed this on Dec 11, 2019

    ---

18. 
    MarcoFalke commented at 2:49 pm on December 11, 2019: member

    Merged, so that everyone can play around with this.
19. sidhujag referenced this in commit da1e7d15d7 on Dec 12, 2019
20. sidhujag referenced this in commit 539a44f576 on Dec 12, 2019
21. sidhujag referenced this in commit 583765cb2e on Nov 10, 2020
22. sidhujag referenced this in commit f8ea209fcf on Nov 10, 2020
23. PastaPastaPasta referenced this in commit 21bd0c30d9 on Jun 27, 2021
24. PastaPastaPasta referenced this in commit 75a7bc2588 on Jun 28, 2021
25. PastaPastaPasta referenced this in commit d3752e2586 on Jun 29, 2021
26. PastaPastaPasta referenced this in commit cfa8bf6ac8 on Jul 1, 2021
27. PastaPastaPasta referenced this in commit 60744f57b7 on Jul 1, 2021
28. PastaPastaPasta referenced this in commit 4b6b47c640 on Jul 14, 2021
29. linuxsh2 referenced this in commit 936542afea on Sep 16, 2021
30. DrahtBot locked this on Dec 16, 2021

Contributors
sipsorcery MarcoFalke

Labels
Tests