`avoid_reuse` support for non-`sendtoaddress` calls #17706

issue instagibbs opened this issue on December 9, 2019
  1. instagibbs commented at 9:34 PM on December 9, 2019: member

    sendmany, bumpfee and others should ideally contain something like this block:

        coin_control.m_avoid_address_reuse = GetAvoidReuseFlag(pwallet, request.params[8]);
        // We also enable partial spend avoidance if reuse avoidance is set.
        coin_control.m_avoid_partial_spends |= coin_control.m_avoid_address_reuse;
    

    to avoid leakage

  2. instagibbs added the label Feature on Dec 9, 2019
  3. instagibbs commented at 7:46 PM on December 12, 2019: member

    hmm this also has to be done for *fund* RPCs and any new coin selection services we end up providing at any endpoint.

    beginning to think we should solve this more systematically than #17712 cc @promag

  4. achow101 commented at 8:24 PM on December 12, 2019: member

    Anything that uses AvailableCoins will already do this: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L2037

  5. instagibbs commented at 8:28 PM on December 12, 2019: member

    huh, I guess sendtoaddress case is just indirection. Fairly confident we have coverage, just hard to read code.

  6. instagibbs closed this on Dec 12, 2019

  7. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me