If I understand http://www.cplusplus.com/reference/mutex/unique_lock/try_lock/ and https://en.cppreference.com/w/cpp/thread/mutex/try_lock correctly, the return value if try_lock already signifies whether the locking was succesful, there is no need to call Base::owns_lock (http://www.cplusplus.com/reference/mutex/unique_lock/owns_lock/) to check.
Should get rid of the following MSVC warning in AppVeyor: "warning C4834: discarding return value of function with 'nodiscard' attribute"
If I understand correctly, the return value if `try_lock` already
signifies whether the locking was succesful, there is no need to
call `Base::owns_lock` to check.
Should get rid of the following MSVC warning in AppVeyor:
"warning C4834: discarding return value of function with 'nodiscard' attribute"
OK this still doesn't fix the AppVeyor build
C:\projects\bitcoin\src\compat\glibcxx_sanity.cpp(50,13): error C2220: the following warning is treated as an error [C:\projects\bitcoin\build_msvc\libbitcoin_util\libbitcoin_util.vcxproj]
C:\projects\bitcoin\src\compat\glibcxx_sanity.cpp(50,13): warning C4834: discarding return value of function with 'nodiscard' attribute [C:\projects\bitcoin\build_msvc\libbitcoin_util\libbitcoin_util.vcxproj]
C:\projects\bitcoin\src\httpserver.cpp(27,10): fatal error C1083: Cannot open include file: 'event2/thread.h': No such file or directory [C:\projects\bitcoin\build_msvc\libbitcoin_server\libbitcoin_server.vcxproj]
C:\projects\bitcoin\src\zmq\zmqconfig.h(15,10): fatal error C1083: Cannot open include file: 'zmq.h': No such file or directory [C:\projects\bitcoin\build_msvc\libbitcoin_zmq\libbitcoin_zmq.vcxproj]
@sipsorcery we shouldn't be compiling glibcxx_sanity.cpp on MSVC!
I don't know where the libevent and zmq errors come from.