Fixing the appveyor build with #17709 has turned into a bigger job than expected. As an interim measure setting the build image back to the previous version of Visual Studio 2019 will fix it immediately.
msvc: Change appveyor build image to previous visual studio 2019. #17710
pull sipsorcery wants to merge 1 commits into bitcoin:master from sipsorcery:appveyor_prev2019 changing 1 files +1 −1-
sipsorcery commented at 11:16 AM on December 10, 2019: member
-
Change appveyor job build image to previous visual studio 2019. 4d7813469c
- fanquake added the label Tests on Dec 10, 2019
-
laanwj commented at 11:23 AM on December 11, 2019: member
back to the previous version of Visual Studio 2019 will fix it immediately.
whoops, apparently it didn't :cry:
-
sipsorcery commented at 12:09 PM on December 11, 2019: member
It did fix the problem it was intended to which was the failing build on the most recent appveyor Visual Studio 2019 image...
The reason for the appveyor failure on this PR was hitting the 1hr limit (previously appveyor seemed to let the Bitcoin Core jobs run over the 1 hr a bit, I saw some up to 1h 14, look like that's been tightened up).
And after that there's about a 25% chance the python functional tests will fail.
To put it In leveldb terms I was using the
narrowdefinition offix.But in seriousness switching to GitHub Actions is looking more appealing if Appveyor are enforcing the 1hr limit. It's a real pain to juggle the Appveyor job to get the vcpkg's installed, force a failure to update the cache, then re-run the job to do that actual build. GitHub Actions don't have the 1hr limit... Admittedly Github Actions do have a 100% failure rate on the python functional tests but if we want them to be reliable on either Windows based CI they need work any way.
-
sipsorcery commented at 10:22 PM on December 11, 2019: member
Best to resolve with #17727 now.
- sipsorcery closed this on Dec 11, 2019
- DrahtBot locked this on Dec 16, 2021
Contributors
Labels