Proposed PSBT sign/broadcast flow #17717

issue gwillen opened this issue on December 10, 2019
  1. gwillen commented at 10:31 PM on December 10, 2019: contributor

    This is a followup to @sjors' PR #17509 . My goal is to propose a very simple initial dialog for the "Load PSBT..." menu item, to go one step beyond just "broadcast or nothing" as the functionality.

    See attached -- the idea is to display a summary of what we know about the transaction and the workflow, and then offer relevant options based on that.

    Thoughts? I want to keep this absolutely as simple as possible this time around (since last time my biggest mistake was trying to do too much at once, I think.)

    IMG_20191210_142555

  2. gwillen added the label Feature on Dec 10, 2019
  3. achow101 commented at 10:53 PM on December 10, 2019: member

    I suppose there should be a button for updating, or maybe update the transaction automatically?

  4. sipa commented at 1:09 AM on December 11, 2019: member

    I like the paper-like style of the interface.

  5. gwillen commented at 6:30 AM on December 11, 2019: contributor

    @achow101 my feeling is that the concept of updating is (1) not going to be obvious to most people what it's for, and (2) very rarely going to be needed as an explicit step in simple cases, because the Core instance generating the transaction will be online. So my feeling is that anytime you generate or load a PSBT in the GUI, we update it automatically before doing anything else.

    Then if you really need an explicit update on some node, you can accomplish it in the GUI with load -> do nothing -> save.

  6. instagibbs commented at 7:13 PM on December 12, 2019: member

    So my feeling is that anytime you generate or load a PSBT in the GUI, we update it automatically before doing anything else.

    Agreed. Perhaps there can be an update message of some kind when loaded if the data is updated.

  7. Sjors commented at 11:30 AM on January 4, 2020: member

    I would replace "Advanced..." with Save and Copy.

  8. Rspigler commented at 4:30 AM on October 27, 2020: contributor

    Can this be closed now with #18027 ?

  9. adamjonas commented at 10:18 PM on January 6, 2021: member

    Agree with rspigler that this can be closed now with #18027 merged.

  10. fanquake closed this on Jan 6, 2021

  11. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me