This mirrors the appveyor config https://github.com/bitcoin/bitcoin/blob/7da9e3a8171f976a9e01ee55ab9fe79bd1f033d1/.appveyor.yml#L10 and is needed for PEP 540
ci: Use python 3.7 on Windows Github Actions #17726
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1912-ciGitHubWindows changing 1 files +8 −7-
MarcoFalke commented at 8:44 PM on December 11, 2019: member
-
ci: Use python 3.7 on Windows Github Actions fabd5b444e
- MarcoFalke requested review from sipsorcery on Dec 11, 2019
- fanquake added the label Tests on Dec 11, 2019
-
sipsorcery commented at 8:47 PM on December 11, 2019: member
I have a feeling I checked this already and that the GitHub Actions Windows images uses Python 3.7 by default.
I dumped the environment variables in one of my runs. I'll track it down and report back.
-
MarcoFalke commented at 8:50 PM on December 11, 2019: member
My testing concluded otherwise, by default 3.6 is used:
python test\functional\test_runner.py --ansi --ci --quiet --combinedlogslen=4000 --failfast --exclude feature_fee_estimation shell: C:\windows\system32\cmd.EXE /D /E:ON /V:OFF /S /C "CALL "{0}"" env: PYTHONUTF8: 1 QT_DOWNLOAD_URL: https://github.com/sipsorcery/qt_win_binary/releases/download/v1.4/Qt5.9.8_x64_static_vs2019.zip QT_DOWNLOAD_HASH: f285cbb02bec3b3f3cc2621e3fa7d5edf0d6a66fa30c57859e583acda954ea80 QT_LOCAL_PATH: C:\Qt5.9.8_x64_static_vs2019 VCPKG_INSTALL_PATH: $env:VCPKG_INSTALLATION_ROOT/installed PLATFORM: x64 --- Logging error --- Traceback (most recent call last): File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\logging\__init__.py", line 996, in emit stream.write(msg) File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\encodings\cp1252.py", line 19, in encode return codecs.charmap_encode(input,self.errors,encoding_table)[0] UnicodeEncodeError: 'charmap' codec can't encode character '\u20bf' in position 127: character maps to <undefined> -
sipsorcery commented at 8:51 PM on December 11, 2019: member
Yes it's 3.6:
PYTHON_HOME=C:/hostedtoolcache/windows\Python\3.6.8\x64Using 3.7 sounds good to me. Don't know if it's present in the image though?
-
MarcoFalke commented at 8:52 PM on December 11, 2019: member
For reference this is the ci run: https://github.com/MarcoFalke/bitcoin-core/commit/fabd5b444ef83b5cd0d63b33bbf6ea4e7557d0eb/checks and I expect it to pass
- sipsorcery approved
-
sipsorcery commented at 9:41 PM on December 11, 2019: member
tACK fabd5b444ef83b5cd0d63b33bbf6ea4e7557d0eb.
-
laanwj commented at 9:51 AM on December 12, 2019: member
ACK fabd5b444ef83b5cd0d63b33bbf6ea4e7557d0eb
- fanquake referenced this in commit 75a2a4f357 on Dec 12, 2019
- fanquake merged this on Dec 12, 2019
- fanquake closed this on Dec 12, 2019
- MarcoFalke deleted the branch on Dec 12, 2019
- PastaPastaPasta referenced this in commit a10da99e98 on Jun 27, 2021
- PastaPastaPasta referenced this in commit 61bc22f159 on Jun 28, 2021
- PastaPastaPasta referenced this in commit d6bbd64778 on Jun 29, 2021
- PastaPastaPasta referenced this in commit 677b18f278 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 7bda8a2558 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 3f2235ec0b on Jul 14, 2021
- DrahtBot locked this on Dec 16, 2021
Contributors
Labels