ci/tests: Bump timeouts so all functional tests run on travis in valgrind #17763

issue MarcoFalke opened this issue on December 17, 2019
  1. MarcoFalke commented at 4:55 PM on December 17, 2019: member

    The newly added valgrind ci run is also run on travis. However, due to the slowdown of valgrind, some tests time out. Fixing this issue might take some time, but it should be rather easy. First, remove this line:

    https://github.com/bitcoin/bitcoin/blob/890eac8f8286496bbae664792cd2a1e56991c669/ci/test/00_setup_env_native_valgrind.sh#L12

    Then, see which tests time out and bump their timeouts. Repeat.

    The purpose of the good first issue label is to highlight which issues are suitable for a new contributor without a deep understanding of the codebase.

    Useful skills:

    Basic skills (Bash, Python, docker, virtual machines, valgrind)

    Want to work on this issue?

    You do not need to request permission to start working on this. You are encouraged to comment on the issue if you are planning to work on it. This will help other contributors monitor which issues are actively being addressed and is also an effective way to request assistance if and when you need it.

    For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

  2. MarcoFalke added the label good first issue on Dec 17, 2019
  3. fanquake added the label Tests on Dec 17, 2019
  4. MarcoFalke commented at 9:45 PM on December 17, 2019: member

    Example diff:

    diff --git a/test/functional/wallet_dump.py b/test/functional/wallet_dump.py
    index 53edf710b..8bd375fc3 100755
    --- a/test/functional/wallet_dump.py
    +++ b/test/functional/wallet_dump.py
    @@ -137,7 +137,7 @@ class WalletDumpTest(BitcoinTestFramework):
     
             # encrypt wallet, restart, unlock and dump
             self.nodes[0].encryptwallet('test')
    -        self.nodes[0].walletpassphrase('test', 10)
    +        self.nodes[0].walletpassphrase('test', 60)
             # Should be a no-op:
             self.nodes[0].keypoolrefill()
             self.nodes[0].dumpwallet(wallet_enc_dump)
    
  5. michiboo commented at 6:37 AM on December 18, 2019: contributor

    Hi I am planning working on this!

  6. MarcoFalke referenced this in commit c26b05c2b7 on Jan 25, 2020
  7. MarcoFalke removed the label good first issue on Jan 25, 2020
  8. MarcoFalke closed this on May 3, 2020

  9. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 00:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me