net: Remove unnecessary portability typedef #17807

On Linux, any type of pointer may be passed as a void* argument. As such, this platform-specific typedef switch is unnecessary.

Note, there is already one usage of setsockopt that directly uses a char*: src/netbase.cpp:926

On Linux, any type of pointer may be passed as a void* argument. As such, this platform-specific typedef switch is unnecessary.

What do you define as platform here? The OS or the compiler?

OS. It was using char* if WIN32, and otherwise void. Can just use char in all cases. If I happen to be mistaken, then the line of code linked to in the description is broken and should use the typedef instead.

Despite being correct I think having the compat explicitly notes an OS difference.

Valid argument. I tend to lean towards code reduction/simplification, but if the consensus is that the documentary aspect of the compat typedefs is more valuable than the LoC reduction, I'm happy to revert. In that case I'd instead like to replace the couple setsockopt uses that still use void/char directly with the typedefs, for consistency.

<!--a722867cd34abeea1fadc8d60700f111-->

Gitian builds

-0 on this. I slightly prefer the current code, as it explicitly notes the platform difference as @promag also says. If you make this change, developers that know about UNIX but not Windows will wonder why the (char*) is there, which adds cognitive load.

Closing this, sorry: there is no strong agreement to make this change.