doc: Added running functional tests in valgrind #17833

pull elichai wants to merge 1 commits into bitcoin:master from elichai:patch-1 changing 1 files +1 −0

elichai commented at 10:41 AM on December 30, 2019: contributor

Technically the notes only show an "example" of how to run valgrind with the suppression file, but now that #17633 is merged then maybe this can encourage more people to run also the functional tests in valgrind
doc: Added running functional tests in valgrind 155a11f897
DrahtBot added the label Docs on Dec 30, 2019

instagibbs commented at 2:09 PM on December 30, 2019: member

MAC build having (unrelated) issue:

Running test/util/bitcoin-util-test.py...
/usr/local/bin/python ../test/util/bitcoin-util-test.py
Traceback (most recent call last):
  File "../test/util/bitcoin-util-test.py", line 14, in <module>
    import configparser
ImportError: No module named configparser

elichai commented at 2:27 PM on December 30, 2019: contributor

MAC build having (unrelated) issue:

Running test/util/bitcoin-util-test.py...
/usr/local/bin/python ../test/util/bitcoin-util-test.py
Traceback (most recent call last):
  File "../test/util/bitcoin-util-test.py", line 14, in <module>
    import configparser
ImportError: No module named configparser

Thanks. yeah, i'm trying to figure out what's going on

in doc/developer-notes.md:253 in 155a11f897
```
 249 | @@ -250,6 +250,7 @@ $ valgrind --suppressions=contrib/valgrind.supp src/test/test_bitcoin
 250 |  $ valgrind --suppressions=contrib/valgrind.supp --leak-check=full \
 251 |        --show-leak-kinds=all src/test/test_bitcoin --log_level=test_suite
 252 |  $ valgrind -v --leak-check=full src/bitcoind -printtoconsole
 253 | +$ ./test/functional/test_runner.py --valgrind
```
jonatack commented at 7:55 AM on December 31, 2019:

Thoughts:

This should wait for #17639

This is example is visible when running .test/functional/test_runner.py --help, which is not the case for the existing examples

There should be a dedicated valgrind doc to link to here, and/or sections in test/README.md and test/functional/README.md about running with valgrind

In general, this section could use more documentation, updating, or a link to more details

This example requires valgrind 3.14 or later, which is not the case for the existing examples, and that should be documented
MarcoFalke commented at 2:20 PM on March 11, 2020: member

@instagibbs python2 is not supported, have you tried with python3?
MarcoFalke merged this on Mar 11, 2020
MarcoFalke closed this on Mar 11, 2020
elichai deleted the branch on Mar 11, 2020
sidhujag referenced this in commit bdfcd43d0c on Mar 11, 2020
therealdannzor commented at 9:46 AM on April 24, 2020: none
Hi @MarcoFalke, I just had the same problem as @instagibbs and I'm also on OSX. You are right in that running python3 ./test/util/bitcoin-util-test.py does work correctly but when running make check in root, it is still on 2.7 as can be seen in the Makefile on L:433 (after building the project).
```
PYTHON = /usr/local/bin/python2.7
```
MarcoFalke commented at 11:26 AM on April 24, 2020: member
This should never happen when python3 is available. The order to pick up python versions is this:
```
$ git grep 'python3.8'
configure.ac:AC_PATH_PROGS([PYTHON], [python3.5 python3.6 python3.7 python3.8 python3 python])
```
sidhujag referenced this in commit 8f6fbc027e on Nov 10, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#17633 tests: Add option --valgrind to run the functional tests under Valgrind