build: Fix –with-gui configure option without argument #17836

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:20191230-fix-withgui changing 1 files +2 −3

hebasto commented at 9:57 pm on December 30, 2019: member
It is expected that --with-gui behaves the same as --with-gui=auto.

But if Qt dependencies not found, configure --with-gui fails rather than warns. See: #17813

Ref: laanwj’s comment from #6938

This PR:
- fixes #17813
- fixes m4 escaping

build: Fix --with-gui configure option without arg

Now --with-gui without argument behaves the same as --with-gui=auto, 
i.e., if Qt is unavailable, it rather warns than fails.

5ac6a1a3ab

build: Fix m4 escaping cfe5e51ddd
fanquake added the label Build system on Dec 30, 2019
fanquake added the label Needs gitian build on Dec 30, 2019
DrahtBot commented at 0:26 am on December 31, 2019: member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:
- #17820 (build: Remove duplicated AC_DEFINE(QT_STATICPLUGIN…) macro by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
hebasto commented at 1:10 am on December 31, 2019: member

Closed in favour of #17820.
hebasto closed this on Dec 31, 2019

DrahtBot commented at 6:02 pm on December 31, 2019: member

Gitian builds

File	commit 8830cb58abc888144a1edb9b2fba427716cc45d8(master)	commit da7d6012a535b0373a8088e126d34701f5d13d93(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`ee3afaebcccbf974...`	`75828cb27e918b8b...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`53eb839c3839f32d...`	`7b61be14f8ad37f5...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`62d69db284fcebea...`	`80acc5faeab09d52...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`ad569636143408b8...`	`86519fbd35546da1...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`ee96491a66eacffd...`	`9aaf2899423fba2a...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`4d4a72b2f7cee148...`	`e37de82b05d17c98...`
bitcoin-0.19.99-osx-unsigned.dmg	`3d6c509abd99dc13...`	`33f2d3b4ac4a5738...`
bitcoin-0.19.99-osx64.tar.gz	`ce1bc5f99820547c...`	`0700a299e2c4ffc4...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`feedb697bd7409f1...`	`b1d716535fd67e37...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`50c8d4d1a0714689...`	`f3909f1ec89f1ce7...`
bitcoin-0.19.99-win64-debug.zip	`171779a3f1818166...`	`7864e2a685ea59c7...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`6e0c7959ceda4156...`	`de16c5d554d881be...`
bitcoin-0.19.99-win64.zip	`155e546e8eee35b0...`	`05fcc1c59453f5be...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`118716702d22fbe8...`	`7bf92b5906f12576...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`120a0036a86ff050...`	`902d538687b62b7a...`
bitcoin-0.19.99.tar.gz	`28be22863a966fd9...`	`ff97d0fc9b4025ab...`
bitcoin-core-linux-0.20-res.yml	`e89e71495e718e4d...`	`07576cd161e7334b...`
bitcoin-core-osx-0.20-res.yml	`2571488485be95ea...`	`e4d313d0114592b0...`
bitcoin-core-win-0.20-res.yml	`cdfab5ec62c485d1...`	`d3c0182f7f081c5f...`
linux-build.log	`808b856809ef9fe5...`	`ff12edb98eca8656...`
osx-build.log	`d0d966aa02921336...`	`42a73d1279877874...`
win-build.log	`d352cbdd46249391...`	`2ef3cf92d635d89f...`
bitcoin-core-linux-0.20-res.yml.diff		`a75ed6871a4c330d...`
bitcoin-core-osx-0.20-res.yml.diff		`73260533949a2530...`
bitcoin-core-win-0.20-res.yml.diff		`1d58de05b1feb19a...`
linux-build.log.diff		`2742b18ff97629a5...`
osx-build.log.diff		`eb396b953c14a2c5...`
win-build.log.diff		`983f508651aa044e...`

DrahtBot removed the label Needs gitian build on Dec 31, 2019
hebasto deleted the branch on Jun 13, 2020
DrahtBot locked this on Feb 15, 2022

Contributors
hebasto DrahtBot

Labels
Build system

build: Fix –with-gui configure option without argument #17836

Conflicts

Gitian builds