build: Refactor out Qt version check macro #17837

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:20191230-autoconf-qt-version-macro changing 1 files +19 −36
  1. hebasto commented at 0:53 am on December 31, 2019: member

    This PR removes code that repeats three times. Also currently on master (8830cb58abc888144a1edb9b2fba427716cc45d8) some parts are brittle:

    https://github.com/bitcoin/bitcoin/blob/8830cb58abc888144a1edb9b2fba427716cc45d8/build-aux/m4/bitcoin_qt.m4#L290

    https://github.com/bitcoin/bitcoin/blob/8830cb58abc888144a1edb9b2fba427716cc45d8/build-aux/m4/bitcoin_qt.m4#L387


    Also there is a little change that fixes a warning:

    0$ cat config.log | grep -A 2 'extra tokens'
    1conftest.cpp:76:28: warning: extra tokens at end of #ifndef directive
    2         #ifndef QT_VERSION OR QT_VERSION_STR
    3                            ^~
    
  2. build: Refactor out Qt version check macro 83db522594
  3. build: Remove extra tokens warning d6d017b125
  4. fanquake added the label Build system on Dec 31, 2019
  5. hebasto commented at 1:10 am on December 31, 2019: member
    Closed in favor of #17820.
  6. hebasto closed this on Dec 31, 2019

  7. DrahtBot locked this on Dec 16, 2021


hebasto

Labels
Build system


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me