gui: uncheck encrypt by default when creating wallet #17879

1. 
   Sjors commented at 4:59 AM on January 6, 2020: member

   Sorry for bike-shedding, but I find this default confusing: <img width="367" alt="Schermafbeelding 2020-01-06 om 12 49 15" src="https://user-images.githubusercontent.com/10217/71795996-b395a800-3083-11ea-8119-8930f096715f.png">

   We don't encrypt the default wallet by default, so I don't think we should do it with new wallets. When creating a watch-only wallet - which I suspect is a more common use case than a second regular wallet - you have to uncheck the box first before you can check the watch-only box.

   This PR unchecks the encryption box by default: <img width="368" alt="Schermafbeelding 2020-01-06 om 12 56 10" src="https://user-images.githubusercontent.com/10217/71796048-f192cc00-3083-11ea-8e83-d136b77d49fc.png">

2. [gui] create wallet: uncheck encrypt by default 4523d0fbbf
3. Sjors force-pushed on Jan 6, 2020
4. fanquake added the label GUI on Jan 6, 2020
5. fanquake requested review from achow101 on Jan 6, 2020
6. 
   achow101 commented at 7:16 PM on January 6, 2020: member

   Concept NACK. I think we should create encrypted wallets by default. It's harder to do that on the command line that it is in the GUI since it requires user interaction.

7. 
   instagibbs commented at 3:00 PM on January 7, 2020: member

   concept NACK in general. Maybe we should allow "Disable private keys" to be clicked, which unclicks the "Encrypt wallet" checkbox?

8. 
   Sjors commented at 6:27 AM on January 8, 2020: member

   Maybe we should allow "Disable private keys" to be clicked, which unclicks the "Encrypt wallet" checkbox?

   That seems like a reasonable UX compromise.

9. Sjors closed this on Jan 8, 2020

   ---

10. 
    luke-jr commented at 7:13 PM on January 26, 2020: member

    tbh, this whole dialog looks very user-unfriendly.

    What does "Make Blank Wallet" even mean to an end user?? ("Disable Private Keys" is probably borderline confusing itself)

11. DrahtBot locked this on Feb 15, 2022

Review Requested
achow101