ci: Combine 32-bit build with CentOS 7 build #17900

pull theStack wants to merge 1 commits into bitcoin:master from theStack:20200108-ci-add-32-bit-centos-build changing 5 files +25 −35
  1. theStack commented at 11:36 am on January 9, 2020: member

    Combines the CentOS build with the 32-bit (i686) build to avoid Travis bottlenecks, as suggested in #17757 by MarcoFalke. This keeps most of the properties of the 32-bit build (dash as config shell, building QT5 GUI) and just builds it with depends inside the CentOS docker container.

    Making the depends in 05_before_script.sh with unset config shell (CONFIG_SHELL=)

    https://github.com/bitcoin/bitcoin/blob/6196e930018181301b5972842ae384ea4288ff34/ci/test/05_before_script.sh#L28

    caused problems for building the library libevent (resulting in a Makefile with no shell set (SHELL=)), that’s why I set it explicitely to /bin/bash if we have a CentOS Docker container.

    A Travis output of this 32-bit CentOS build can be seen here: https://travis-ci.org/theStack/bitcoin/jobs/634472394 (has been restarted once due to too long build time and appearance of the CACHE_ERR_MSG).

    For anyone wanting to verify the outputs, I found these instructions useful to reproduce a Travis build locally: https://github.com/erdc/proteus/wiki/Replicating-the-TravisCI-Environment-on-your-Local-Machine (steps 1-3). In this case it’s a bit tricky since you run Docker inside Docker – within the Travis Docker container, the CentOS Docker container is created. To make this possible, the Docker socket has to be exposed to the Travis container via bind-mounting (docker run -v /var/run/docker.sock:/var/run/docker.sock ...), as suggested in https://stackoverflow.com/a/33003273.

  2. ci: Combine 32-bit build with CentOS 7 build ef63f5fc11
  3. fanquake added the label Tests on Jan 9, 2020
  4. hebasto commented at 5:26 pm on January 9, 2020: member
    One of the initial goals to run CentOS task on Travis was to check the Bitcoin Core compatibility with aged (system) dependencies. Using our built depends/ eliminates this achievement, no?
  5. MarcoFalke commented at 5:40 pm on January 9, 2020: member
    32-bit gitian is going to be removed, so we might as well not use depends in here. See #17504
  6. theStack commented at 6:45 pm on January 9, 2020: member

    One of the initial goals to run CentOS task on Travis was to check the Bitcoin Core compatibility with aged (system) dependencies. Using our built depends/ eliminates this achievement, no?

    Without building the depends I don’t see a way to do a cross-compile from 64 bit to 32 bit, one would need all the needed libraries also for i686, which is unfortunately not the case in CentOS 7 – the following packages are only available for x86_64: libdb4-devel, libdb4-cxx-devel, miniupnpc-devel, zeromq-devel.

  7. hebasto commented at 7:58 pm on January 9, 2020: member
  8. laanwj commented at 9:07 am on January 10, 2020: member

    Concept ACK

    32-bit gitian is going to be removed, so we might as well not use depends in here. See #17504

    I’m not sure 32-bit gitian binaries and depends 32-bit support should be equated here. Deciding not to ship 32 bit gitian binaries does not necessarily mean making it harder to build on/for 32 bit for those that still want to. I dunno.

  9. DrahtBot commented at 6:16 pm on January 10, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    No conflicts as of last run.

  10. MarcoFalke referenced this in commit 2aaeca50b2 on Jan 16, 2020
  11. MarcoFalke merged this on Jan 16, 2020
  12. MarcoFalke closed this on Jan 16, 2020

  13. sidhujag referenced this in commit 09a11058a7 on Jan 17, 2020
  14. sidhujag referenced this in commit ecc8847f84 on Nov 10, 2020
  15. theStack deleted the branch on Dec 1, 2020
  16. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me