rpc: Don't lock cs_main in getblock if verbosity=0 #17930

pull promag wants to merge 1 commits into bitcoin:master from promag:2020-01-getblock-avoid-lock changing 1 files +8 −8

promag commented at 12:30 PM on January 15, 2020: member

This move-only change removes the unnecessary cs_main lock when verbosity == 0.
rpc: Don't lock cs_main in getblock if verbosity=0 9ccb3bcce5
fanquake added the label RPC/REST/ZMQ on Jan 15, 2020

in src/rpc/blockchain.cpp:897 in 9ccb3bcce5

 893 | @@ -894,6 +894,14 @@ static UniValue getblock(const JSONRPCRequest& request)
 894 |              verbosity = request.params[1].get_bool() ? 1 : 0;
 895 |      }
 896 |  
 897 | +    if (verbosity <= 0)

promag commented at 12:31 PM on January 15, 2020:

No, I don't want to fix the style, move-only.

promag closed this on Jan 15, 2020
promag deleted the branch on Jan 15, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

promag

Labels

RPC/REST/ZMQ