To reproduce bug, open 2 wallets, and close 1. You end up left without the HD/encrypt icons, despite having a wallet open still.
This works because the icons are re-shown after we remove the current wallet (if there's another wallet still open).
Bugfix: GUI: Hide the HD/encrypt icons earlier so they get re-shown if another wallet is open #18007
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:bugfix_for_pr17935 changing 1 files +4 −2-
luke-jr commented at 10:56 PM on January 26, 2020: member
-
Bugfix: GUI: Hide the HD/encrypt icons earlier so they get re-shown if another wallet is open 4c524f0aad
- fanquake added the label GUI on Jan 26, 2020
-
promag commented at 1:16 AM on January 27, 2020: member
Tested ACK 4c524f0aad11b44baa56d2b2e432bbddffff74c2.
-
jonasschnelli commented at 10:16 AM on January 27, 2020: contributor
utACK 4c524f0aad11b44baa56d2b2e432bbddffff74c2
I guess this should be backported.
- jonasschnelli added the label Needs backport (0.19) on Jan 27, 2020
- jonasschnelli added the label Needs backport (0.18) on Jan 27, 2020
- hebasto approved
-
hebasto commented at 2:09 PM on January 27, 2020: member
ACK 4c524f0aad11b44baa56d2b2e432bbddffff74c2, tested on Linux Mint 19.3.
To reproduce bug, open 2 wallets, and close 1. You end up left without the HD/encrypt icons, despite having a wallet open still.
Bug confirmed. This PR fixes it.
- jonasschnelli referenced this in commit ef8e2cee9f on Jan 27, 2020
- jonasschnelli merged this on Jan 27, 2020
- jonasschnelli closed this on Jan 27, 2020
-
luke-jr commented at 3:32 PM on January 27, 2020: member
@jonasschneli The bug was introduced in #17935 which is only in master afaik?
- jonasschnelli removed the label Needs backport (0.18) on Jan 27, 2020
- jonasschnelli removed the label Needs backport (0.19) on Jan 27, 2020
-
jonasschnelli commented at 4:59 PM on January 27, 2020: contributor
Thanks @luke-jr. I just removed the labels.
- MarkLTZ referenced this in commit d99bc96496 on Feb 13, 2020
- jasonbcox referenced this in commit 65c02eebfa on Sep 23, 2020
- PastaPastaPasta referenced this in commit f21d15a233 on Sep 17, 2021
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels