bench: Fix benchmarks filters #18013

1. 
   elichai commented at 3:11 pm on January 28, 2020: contributor

   The bug was introduced in #17781 before this fix ./src/bench/bench_bitcoin -filter=* will fail with:

   0# Benchmark, evals, iterations, total, min, max, median
   1bench_bitcoin: bench/bench.cpp:119: static void benchmark::BenchRunner::RunAll(benchmark::Printer&, uint64_t, double, const string&, bool): Assertion `g_testing_setup == nullptr' failed.
   2Aborted (core dumped)
   

2. Fix benchmarks filters 0dae5a5c34
3. 
   MarcoFalke commented at 3:14 pm on January 28, 2020: member

   ACK 0dae5a5c34ef54ad912382836d12688813745bc5

   Thanks for the fix

4. MarcoFalke added the label Tests on Jan 28, 2020
5. 
   instagibbs commented at 3:15 pm on January 28, 2020: member

   I wonder if there might be a good place to add a really basic CI test that makes sure bench jobs can run successfully?
6. 
   MarcoFalke commented at 3:16 pm on January 28, 2020: member

   @instagibbs There is, and all benches do run successfully. This fixes an issue where the --filter=.... option no longer works correctly, which we don’t check in CI
7. 
   instagibbs commented at 3:18 pm on January 28, 2020: member

   @MarcoFalke ok well that’s a suggestion :)
8. 
   MarcoFalke commented at 3:23 pm on January 28, 2020: member

   Here is the existing check, which is run in ci: https://github.com/bitcoin/bitcoin/blob/94c6f2bba45100abeaf310057a989f8644115eaf/src/Makefile.test.include#L594
9. 
   DrahtBot commented at 4:58 pm on January 28, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18011 (Replace current benchmarking framework with nanobench by martinus)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

10. 
    emilengler commented at 5:24 pm on January 28, 2020: contributor

    I get this error:

    0$ src/bench/bench_bitcoin -filter=*
    1terminate called after throwing an instance of 'std::regex_error'
    2  what():  regex_error
    

    Am I doing something wrong

11. 
    elichai commented at 5:28 pm on January 28, 2020: contributor

    I get this error:

    0$ src/bench/bench_bitcoin -filter=*
    1terminate called after throwing an instance of 'std::regex_error'
    2  what():  regex_error
    

    Am I doing something wrong

    that seems to be unrelated to the bug I’m fixing, the regex engine here(std::regex) isn’t great. Try something like -filter=RIPEMD160|SHA256|SHA1

12. MarcoFalke referenced this in commit fe48ac8580 on Jan 28, 2020
13. MarcoFalke merged this on Jan 28, 2020
14. MarcoFalke closed this on Jan 28, 2020

    ---

15. Fabcien referenced this in commit 8d80549973 on Dec 18, 2020
16. PastaPastaPasta referenced this in commit f473cf0c4f on Jun 27, 2021
17. PastaPastaPasta referenced this in commit 74efdbc95d on Jun 28, 2021
18. PastaPastaPasta referenced this in commit a80f20b943 on Jun 29, 2021
19. DrahtBot locked this on Feb 15, 2022

Contributors
elichai MarcoFalke instagibbs DrahtBot emilengler

Labels
Tests