bench: Fix benchmarks filters #18013

The bug was introduced in #17781 before this fix ./src/bench/bench_bitcoin -filter=* will fail with:

# Benchmark, evals, iterations, total, min, max, median
bench_bitcoin: bench/bench.cpp:119: static void benchmark::BenchRunner::RunAll(benchmark::Printer&, uint64_t, double, const string&, bool): Assertion `g_testing_setup == nullptr' failed.
Aborted (core dumped)

ACK 0dae5a5c34ef54ad912382836d12688813745bc5

Thanks for the fix

I wonder if there might be a good place to add a really basic CI test that makes sure bench jobs can run successfully?

@instagibbs There is, and all benches do run successfully. This fixes an issue where the --filter=.... option no longer works correctly, which we don't check in CI

@MarcoFalke ok well that's a suggestion :)

Here is the existing check, which is run in ci: https://github.com/bitcoin/bitcoin/blob/94c6f2bba45100abeaf310057a989f8644115eaf/src/Makefile.test.include#L594

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #18011 (Replace current benchmarking framework with nanobench by martinus)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

I get this error:

$ src/bench/bench_bitcoin -filter=*
terminate called after throwing an instance of 'std::regex_error'
  what():  regex_error

Am I doing something wrong

I get this error:

$ src/bench/bench_bitcoin -filter=*
terminate called after throwing an instance of 'std::regex_error'
  what():  regex_error

Am I doing something wrong

that seems to be unrelated to the bug I'm fixing, the regex engine here(std::regex) isn't great. Try something like -filter=RIPEMD160|SHA256|SHA1