gui: Drop BanTableModel dependency to ClientModel #18035

1. 
   promag commented at 0:15 am on January 31, 2020: member

   Trivial change since ClientModel is not used by BanTableModel.
2. gui: Drop BanTableModel dependency to ClientModel 8eec9c7989
3. promag requested review from hebasto on Jan 31, 2020
4. fanquake added the label GUI on Jan 31, 2020
5. jonasschnelli approved
6. 
   jonasschnelli commented at 7:57 am on January 31, 2020: contributor

   Thanks for the cleanup.

   utACK 8eec9c79890649044083c78c5f34019126aea561

7. in src/qt/bantablemodel.cpp:12 in 8eec9c7989

    5@@ -6,11 +6,10 @@
    6 
    7 #include <interfaces/node.h>
    8 #include <net_types.h> // For banmap_t
    9-#include <qt/clientmodel.h>
   10 
   11 #include <utility>
   12 
   13-#include <QDebug>
   14+#include <QDateTime>
   

   ---

   ---

   

   hebasto commented at 8:06 am on January 31, 2020:

   nit: while here, <QVariant> and <QModelIndex> could also be added.

   ---

   

   promag commented at 8:19 am on January 31, 2020:

   Done, and pushed to #18036.
8. in src/qt/bantablemodel.h:47 in 8eec9c7989

   43@@ -45,7 +44,7 @@ class BanTableModel : public QAbstractTableModel
   44     Q_OBJECT
   45 
   46 public:
   47-    explicit BanTableModel(interfaces::Node& node, ClientModel *parent = nullptr);
   48+    explicit BanTableModel(interfaces::Node& node, QObject* parent = nullptr);
   

   ---

   ---

   

   hebasto commented at 8:09 am on January 31, 2020:

   nit: not allowing default parent seems safer w.r.t. Qt parent-child properties.

   0    explicit BanTableModel(interfaces::Node& node, QObject* parent);
   

   ---

   

   promag commented at 8:19 am on January 31, 2020:

   Done, and pushed to #18036
9. hebasto approved
10. 
    hebasto commented at 8:10 am on January 31, 2020: member

    ACK 8eec9c79890649044083c78c5f34019126aea561, tested on Linux Mint 19.3
11. 
    promag commented at 8:19 am on January 31, 2020: member

    Included in #18036.
12. promag closed this on Jan 31, 2020

    ---

13. promag deleted the branch on Jan 31, 2020
14. DrahtBot locked this on Feb 15, 2022

Contributors
promag jonasschnelli hebasto

Labels
GUI