See #18019. The current solution looks like this (I also tested with multiple submodules):
0These submodules were found, delete them:
1 355a5a310019659d9bf6818d2fd66fbb214dfed7 curl (curl-7_68_0-108-g355a5a310)
The submodule example command was git submodule add https://github.com/curl/curl.git curl
0@@ -0,0 +1,18 @@
1+#!/bin/sh
0#!/usr/bin/env bash
13+ echo Delete the submodules:
14+ echo $CMD
15+ EXIT_CODE=1
16+fi
17+
18+exit $EXIT_CODE
0@@ -0,0 +1,18 @@
1+#!/bin/sh
2+#
3+# Copyright (c) 2020 The Bitcoin Core developers
4+# Distributed under the MIT software license, see the accompanying
5+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
6+export LC_ALL=C
7+EXIT_CODE=0
8+
9+CMD=$(find . -type f | grep .gitmodules)
Concept ACK, thanks for working on this.
Wouldn’t it be preferable to ask git directly with git submodule status instead of looking for .gitmodules (which is an implementation detail)?
Updated the script with a git based solution. If a submodule was found it’ll look like this (I used https://github.com/curl/curl.git in this example)
0Delete the submodules:
15ce7102ceae250e2d31b54aad2f33b3bc35f243a curl (curl-7_68_0-99-g5ce7102ce)
0@@ -0,0 +1,18 @@
1+#!/usr/bin/env bash
2+#
3+# Copyright (c) 2020 The Bitcoin Core developers
4+# Distributed under the MIT software license, see the accompanying
5+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
# Check for git submodules.”) following an empty line (see other scripts in this subdir as an example).
0@@ -0,0 +1,18 @@
1+#!/usr/bin/env bash
2+#
3+# Copyright (c) 2020 The Bitcoin Core developers
4+# Distributed under the MIT software license, see the accompanying
5+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
6+export LC_ALL=C
7+EXIT_CODE=0
8+
9+CMD=$(git submodule status --recursive)
0CMD=$(git submodule status)
If this script reports submodules which should be deleted, it should not list nested ones.
If an “outer” submodule will be deleted, the nested submodule will be deleted automatically (as it resides in the subdirectory of the “outer” submodule), no?
It seems no need in “delete them” instruction to a user point to nested submodules.
6+export LC_ALL=C
7+EXIT_CODE=0
8+
9+CMD=$(git submodule status --recursive)
10+if [[ ${CMD} ]]
11+then
if test -n "$CMD"; then seems more explicit.
nit: curly braces are redundant here.
8+
9+CMD=$(git submodule status --recursive)
10+if [[ ${CMD} ]]
11+then
12+ echo These submodules were found, delete them:
13+ echo $CMD
0 echo "$CMD"
…otherwise, script will print multiple submodules in a line.
0@@ -0,0 +1,20 @@
1+#!/usr/bin/env bash
2+#
3+# Copyright (c) 2020 The Bitcoin Core developers
4+# Distributed under the MIT software license, see the accompanying
5+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
6+#
7+# This script checks for git modules
