What about the script to strip spaces and tabs from source? #1806

issue Diapolo opened this issue on September 9, 2012
  1. Diapolo commented at 9:14 AM on September 9, 2012: none

    @jgarzik I'm rather sure there was broad developer consensus to do that before 0.7 get's final :)?

  2. laanwj commented at 9:45 AM on September 9, 2012: member

    I still don't see the point. Changes like removing spaces are fine when you're editing a part of the source, but I really dislike automated "beautification" passes over the code.

    This one isn't so bad, but I've seen it going from bad to worse in projects, with a large part of changes consisting of automated reformatting / reindentations.

    As long as standard diff tools still work on a line-based instead of semantic basis, this is annoying, and makes tracking real important changes in a project harder.

  3. jgarzik commented at 3:36 PM on September 9, 2012: contributor

    There are really only a few left, so such criticisms are very overblown.

  4. laanwj commented at 4:46 PM on September 9, 2012: member

    Ok, maybe I exaggerated a bit (color me traumatized :) ), let's try it out and see.

  5. Diapolo commented at 7:27 AM on September 11, 2012: none

    I'm going to remove such stuff with future pulls, when I observe such occurrences and they fit in then. But AFAIK the script changes won't be that invasive.

  6. laanwj commented at 8:06 AM on September 21, 2012: member

    this was already done, closing

  7. laanwj closed this on Sep 21, 2012

  8. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me