Remove VC6 comment and pointless #ifdef'd benchmark code #1808

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2012_09_serialize_deadcode changing 1 files +0 −52

laanwj commented at 3:27 PM on September 9, 2012: member

We're in a wholly different world now, C++-compiler-wise.

Current std::stringstream implementations don't have the stated problem anymore, and are just as fast as CDataStream.

The #ifdef'd block does not even compile anymore; CDataStream constructor changed, and missing some std::. Also timing in whole seconds is also way too granular to say anything sensible in such microbenchmarks. Just remove it, it can always be found again in git history.

Remove VC6 comment and pointless #ifdef'd benchmark code

We're in a wholly different world now, C++-compiler-wise.

Current std::stringstream implementations don't have the stated problem anymore,
and are just as fast as CDataStream.

The #ifdef'd block does not even compile anymore; CDataStream constructor changed,
and missing some std::. Also timing in whole seconds is also way too granular
to say anything sensible in such microbenchmarks. Just remove it,
it can always be found again in git history.

b019ea17ec

jgarzik commented at 3:39 PM on September 9, 2012: contributor

ACK
laanwj referenced this in commit 0e08efc54a on Sep 9, 2012
laanwj merged this on Sep 9, 2012
laanwj closed this on Sep 9, 2012
BitcoinPullTester commented at 1:14 AM on September 10, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b019ea17ec7cc37d098982b4f0f4636e424ab4b8 for binaries and test log.
laanwj deleted the branch on Apr 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

laanwj

jgarzik

BitcoinPullTester