[0.19] wallet: Reset reused transactions cache #18083

1. 
   luke-jr commented at 5:23 AM on February 6, 2020: member

   Backport of #17843

   Required porting to pre-WalletBatch

2. wallet: Reset reused transactions cache

   If a destination is reused we mark the cache of the other transactions going to that destination dirty so they are not accidentally reported as trusted when the cache is hit.
   
   Github-Pull: #17843
   Rebased-From: 6fc554f591d8ea1681b8bb25aa12da8d4f023f66

   f11872cbf4
3. fanquake added the label Backport on Feb 6, 2020
4. fanquake added the label Wallet on Feb 6, 2020
5. luke-jr requested review from achow101 on Feb 6, 2020
6. luke-jr requested review from kallewoof on Feb 6, 2020
7. luke-jr requested review from meshcollider on Feb 6, 2020
8. luke-jr requested review from promag on Feb 6, 2020
9. 
   kallewoof commented at 6:53 AM on February 9, 2020: member

   Code review ACK f11872cbf46128e22e33c3138755c4aa32e80de7

   Compared code to #17843 and verified it is the same code. The only notable difference is the WalletBatch in the new code vs uint256 in the old one, which is an unrelated change stemming from #17354.

10. kallewoof approved
11. 
    meshcollider commented at 9:19 AM on February 9, 2020: contributor

    utACK f11872cbf46128e22e33c3138755c4aa32e80de7

12. 
    MarcoFalke commented at 3:29 PM on February 9, 2020: member

    cc @fjahr

13. 
    laanwj commented at 12:03 PM on February 10, 2020: member

    code review ACK f11872cbf46128e22e33c3138755c4aa32e80de7

14. laanwj referenced this in commit 4755037d45 on Feb 10, 2020
15. laanwj merged this on Feb 10, 2020
16. laanwj closed this on Feb 10, 2020

    ---

17. MarkLTZ referenced this in commit d99bc96496 on Feb 13, 2020
18. Munkybooty referenced this in commit e16b702861 on Dec 9, 2021
19. DrahtBot locked this on Feb 15, 2022

Review Requested
promagachow101