scripted-diff: Add missing spaces in RPCResult, Normalize type names #18098

1. 
   MarcoFalke commented at 1:14 pm on February 9, 2020: member

   This makes the rendered diff smaller when the RPCResult is machine generated later on (Previous attempts: #14601 and #14459)
2. scripted-diff: Add missing spaces in RPCResult, Fix type names

   This makes the rendered diff smaller when the RPCResult is machine
   generated later on
   
   -BEGIN VERIFY SCRIPT-
    # Add space after dictionary key and before colon
    sed -i --regexp-extended -e 's/(^ +" +\\"[a-zA-Z_]+\\"): ?/\1 : /g' $(git grep -l '\\":')
    # Rename (array) to (json array)
    sed -i -e 's/ (array) / (json array) /g' $(git grep -l '(array)' ./src)
    # Rename (object) to (json object)
    sed -i -e 's/ (object) / (json object) /g' $(git grep -l '(object)' ./src)
    # Rename (bool) to (boolean)
    sed -i -e 's/ (bool) / (boolean) /g' $(git grep -l '(bool)' ./src)
    # Rename (int) to (numeric)
    sed -i -e 's/  (int) /  (numeric) /g' $(git grep -l '(int)' ./src)
   -END VERIFY SCRIPT-

   fad027fb0c
3. MarcoFalke added the label Docs on Feb 9, 2020
4. MarcoFalke added the label RPC/REST/ZMQ on Feb 9, 2020
5. 
   DrahtBot commented at 2:55 pm on February 9, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17812 (config, net, test: asmap functional tests and feature refinements by jonatack)
   • #17566 (Switch to weight units for all feerates computation by darosior)
   • #17034 (Bip174 extensions by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   Sjors commented at 12:16 pm on February 14, 2020: member

   ACK fad027fb0ce019f31b20861c37e802d4e29e6931
7. MarcoFalke referenced this in commit 263f53e2d0 on Feb 17, 2020
8. MarcoFalke merged this on Feb 17, 2020
9. MarcoFalke closed this on Feb 17, 2020

   ---

10. MarcoFalke deleted the branch on Feb 17, 2020
11. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke DrahtBot Sjors

Labels
Docs RPC/REST/ZMQ