This makes the rendered diff smaller when the RPCResult is machine generated later on (Previous attempts: #14601 and #14459)
scripted-diff: Add missing spaces in RPCResult, Normalize type names #18098
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1912-rpcDocFixes changing 8 files +315 −315-
MarcoFalke commented at 1:14 PM on February 9, 2020: member
-
fad027fb0c
scripted-diff: Add missing spaces in RPCResult, Fix type names
This makes the rendered diff smaller when the RPCResult is machine generated later on -BEGIN VERIFY SCRIPT- # Add space after dictionary key and before colon sed -i --regexp-extended -e 's/(^ +" +\\"[a-zA-Z_]+\\"): ?/\1 : /g' $(git grep -l '\\":') # Rename (array) to (json array) sed -i -e 's/ (array) / (json array) /g' $(git grep -l '(array)' ./src) # Rename (object) to (json object) sed -i -e 's/ (object) / (json object) /g' $(git grep -l '(object)' ./src) # Rename (bool) to (boolean) sed -i -e 's/ (bool) / (boolean) /g' $(git grep -l '(bool)' ./src) # Rename (int) to (numeric) sed -i -e 's/ (int) / (numeric) /g' $(git grep -l '(int)' ./src) -END VERIFY SCRIPT-
- MarcoFalke added the label Docs on Feb 9, 2020
- MarcoFalke added the label RPC/REST/ZMQ on Feb 9, 2020
- MarcoFalke cross-referenced this on Feb 9, 2020 from issue rpc: Auto-format RPCResult by MarcoFalke
-
DrahtBot commented at 2:55 PM on February 9, 2020: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #17812 (config, net, test: asmap functional tests and feature refinements by jonatack)
- #17566 (Switch to weight units for all feerates computation by darosior)
- #17034 (Bip174 extensions by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Feb 11, 2020 from issue config, net, test: asmap feature refinements and functional tests by jonatack
- DrahtBot cross-referenced this on Feb 11, 2020 from issue Switch to weight units for all feerates computation by darosior
- DrahtBot cross-referenced this on Feb 11, 2020 from issue [BIP 174] PSBT version, proprietary, and xpub fields by achow101
-
Sjors commented at 12:16 PM on February 14, 2020: member
ACK fad027fb0ce019f31b20861c37e802d4e29e6931
- MarcoFalke referenced this in commit 263f53e2d0 on Feb 17, 2020
- MarcoFalke merged this on Feb 17, 2020
- MarcoFalke closed this on Feb 17, 2020
- MarcoFalke deleted the branch on Feb 17, 2020
- MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
- bitcoin locked this on Feb 15, 2022
