I found it really helpful when debugging stuff to not need to delete the debug.log everytime I re-start the client.
- changes ShrinkDebugFile() function to use nice MiB and KiB boundaries
I found it really helpful when debugging stuff to not need to delete the debug.log everytime I re-start the client.
I found it really helpful when debugging stuff to not need to delete the
debug.log everytime I re-start the client.
- changes ShrinkDebugFile() function to use nice MiB and KiB boundaries
As much as I prefer using historically-standard KB/MB units in general, this client has always used SI-standard kB/MB units consistently. So ACK changing it (ideally everywhere), and ACK leaving it alone too ;)
On the new commandline option, I feel we are getting a bit too much code to configure a mere debug log. In this case, it should be just as easy to use your OS's rm/del command immediately before launching bitcoind. Is there any reason to have it builtin?
Removing debug logs is one of these actions that can easily be done in the script that launches bitcoin(d). It's not worth adding yet another command-line flag for.
Let's keep command line options for bitcoin/network-related settings.
NACK. I agree with @laanwj
Closing for getting too much NACKs ^^.
Automatic sanity-testing: FAILED MERGE, see http://jenkins.bluematt.me/pull-tester/0de15d3f386852d8afb30be85c0f53a3274897f6 for test log.
This pull does not merge cleanly onto current master