contrib/devtools/previous_release.sh should be rewritten to python #18132

1. 
   MarcoFalke commented at 8:15 pm on February 12, 2020: member

   Most of our test scripts are written in python. We don’t have enough reviewers for bash scripts and they tend to be clumsy anyway. Especially when it comes to argument parsing.

   Thus, contrib/devtools/previous_release.sh should be rewritten in python

   Useful skills:

   Experience with Bash and Python

   Want to work on this issue?

   The purpose of the good first issue label is to highlight which issues are suitable for a new contributor without a deep understanding of the codebase.

   You do not need to request permission to start working on this. You are encouraged to comment on the issue if you are planning to work on it. This will help other contributors monitor which issues are actively being addressed and is also an effective way to request assistance if and when you need it.

   For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

2. MarcoFalke added the label Tests on Feb 12, 2020
3. MarcoFalke added the label good first issue on Feb 12, 2020
4. 
   bboot commented at 8:33 pm on February 12, 2020: none

   I am starting work on this today.
5. 
   theStack commented at 7:01 pm on February 13, 2020: member

   A description of the scripts purpose / usage examples etc. is missing in contrib/devtools/README.md as well.
6. 
   bboot commented at 7:00 am on February 14, 2020: none

   Ok.
7. 
   bboot commented at 8:31 am on February 24, 2020: none

   I have the code here: https://github.com/bboot/bitcoin/tree/previous-release-py

   Still going to update the README before making a pull request. I would like to make a change to check file hash before untarring when using the binary download option, but not sure if this should just focus on conversion to python and keeping the logic the same.

8. 
   MarcoFalke commented at 8:56 pm on March 2, 2020: member

   No need to keep the logic 1:1 identical. You can do pretty much anything that makes the resulting python code look good.
9. 
   MarcoFalke commented at 2:57 pm on March 10, 2020: member

   @bboot are you still working on this?
10. 
    rja907 commented at 1:50 am on April 25, 2020: none

    @MarcoFalke, do you think this is a good first issue? I want to start contributing during weekends.
11. 
    MarcoFalke commented at 12:26 pm on April 25, 2020: member

    @bboot hasn’t responded in two months, so the code from https://github.com/bboot/bitcoin/tree/previous-release-py can be picked up (while keeping authorship attribution) and then submitted as a pull request here.
12. 
    bliotti commented at 2:27 pm on June 6, 2020: contributor

    I am going to try and add @bboot’s idea to check the file hash.
13. bliotti referenced this in commit 2cea953e6a on Jun 8, 2020
14. bliotti referenced this in commit 5b745f24fc on Jun 8, 2020
15. bliotti referenced this in commit 53d10682b4 on Jun 9, 2020
16. bliotti referenced this in commit bae2e85aaa on Jun 29, 2020
17. bliotti referenced this in commit 33cbb5840f on Jun 30, 2020
18. bliotti referenced this in commit a93248f756 on Jul 2, 2020
19. bliotti referenced this in commit 45c76d7889 on Jul 2, 2020
20. bliotti referenced this in commit 53f2f9db20 on Jul 4, 2020
21. bliotti referenced this in commit e1e5960e10 on Jul 5, 2020
22. MarcoFalke referenced this in commit ea595d39f7 on Jul 21, 2020
23. MarcoFalke closed this on Jul 21, 2020

    ---

24. sidhujag referenced this in commit 4dc1afd34b on Jul 21, 2020
25. JeremyRubin referenced this in commit 5c338762b5 on Jul 27, 2020
26. Warchant referenced this in commit 2c78fe3bfd on Aug 6, 2020
27. laanwj referenced this in commit 16b784d953 on Jan 29, 2021
28. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke bboot theStack rja907 bliotti

Labels
Tests good first issue