refactor / optimizations: feebumper #18146

pull sanjaykdragon wants to merge 1 commits into bitcoin:master from sanjaykdragon:patch-1 changing 1 files +4 −3

sanjaykdragon commented at 2:58 PM on February 14, 2020: contributor

Minor optimization - stop calling GetHash so much

refactor / optimizations: feebumper

Minor optimization - stop calling GetHash so much

51adb68f7b

theStack commented at 3:53 PM on February 14, 2020: member

Both CWalletTx::GetHash() and CTransaction::GetHash() are just simple getter-methods returning the value of a member variable (i.e. not computing anything) and both of them are implemented in their header files, enabling inlining, hence I highly doubt that this is bringing any performance improvement.
DrahtBot added the label Wallet on Feb 14, 2020
sanjaykdragon commented at 4:06 PM on February 14, 2020: contributor

Both CWalletTx::GetHash() and CTransaction::GetHash() are just simple getter-methods returning the value of a member variable (i.e. not computing anything) and both of them are implemented in their header files, enabling inlining, hence I highly doubt that this is bringing any performance improvement.

Didn't know that, thought that GetHash did some computations
sanjaykdragon closed this on Feb 14, 2020
sanjaykdragon deleted the branch on Feb 14, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels