rpc: generalize address in decoderawtransaction RPCResult #18164

pull theStack wants to merge 1 commits into bitcoin:master from theStack:20200216-rpc-remove-concrete-address-from-rpcresult changing 1 files +1 −1
  1. theStack commented at 10:28 pm on February 16, 2020: member
    Another small step to get rid of legacy addresses in the RPC help texts – for a RPCResult in fact we don’t want to see any concrete address at all. All other RPCs containing the "addresses" array in the RPCResults (e.g. getrawtransaction, decodescript) show a generic “address” string instead of a concrete address, so we adapt this here as well.
  2. rpc: generalize address in decoderawtransaction RPCResult
    All other RPCs containing the "addresses" array in the RPCResults (e.g.
    getrawtransaction, decodescript) show a generic "address" string instead of a
    concrete address, so we adapt this here as well.
    6e205eba9a
  3. fanquake added the label RPC/REST/ZMQ on Feb 16, 2020
  4. MarcoFalke commented at 0:39 am on February 17, 2020: member
    I’d prefer if this was done after #17809
  5. DrahtBot commented at 3:51 am on February 17, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #17809 (rpc: Auto-format RPCResult by MarcoFalke)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. emilengler commented at 3:00 pm on February 19, 2020: contributor
    Concept ACK but like Marco said #17809 has priority. Maybe base this PR on the head commit of #17809 PR?
  7. theStack commented at 12:55 pm on February 25, 2020: member
    @MarcoFalke, @emilengler: #17809 already contains the change from this PR, hence it can be closed as soon as #17809 is merged.
  8. DrahtBot added the label Needs rebase on Mar 4, 2020
  9. DrahtBot commented at 2:26 pm on March 4, 2020: member
  10. MarcoFalke commented at 2:36 pm on March 4, 2020: member

    @MarcoFalke, @emilengler: #17809 already contains the change from this PR, hence it can be closed as soon as #17809 is merged.

    Ok, closing then.

  11. MarcoFalke closed this on Mar 4, 2020

  12. MarcoFalke locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me