rpc: sendtoaddress and sendmany should return PSBT for watch-only wallet #18180

1. 
   Sjors commented at 3:57 pm on February 19, 2020: member

   Similar to bumpfee #16373, I would like sendtoaddress and sendmany to return a PSBT when used on a watch-only wallet. These methods are easier to use than walletcreatefundedpsbt.

   I added this functionally as part of external signer support in #16546, which helps keep that PR short. But I think it makes sense as a standalone PR.

2. Sjors added the label Feature on Feb 19, 2020
3. 
   Sjors commented at 4:02 pm on February 19, 2020: member

   Probably best built on top of #18115.

   cc @instagibbs, @achow101: how does this fit in the (Legacy/Descriptor)ScriptPubKeyMan architecture? Right now these methods use an RPC helper SendMoney, which in turn calls wallet->CreateTransaction and pwallet->CommitTransaction(). What’s the appropriate place to make it call either FillPSBT() or SignTransaction() on the ScriptPubKeyMan?

4. 
   Sjors commented at 3:34 pm on February 21, 2020: member

   For sendmany the change is pretty straight-forward, see https://github.com/bitcoin/bitcoin/pull/16546/commits/2a04b969d8f97581f741798f57e4d80c6657ec4b
5. 
   promag commented at 11:11 pm on March 15, 2020: member

   From #16378

   This paves the way for deprecating sendtoaddress and sendmany though there’s no rush. The only missing feature compared to these older methods is adding labels to a destination address.

   But here you want to add more features to these RPC :sweat_smile:

6. 
   Sjors commented at 5:27 pm on March 17, 2020: member

   Things change quickly! Closing this.
7. Sjors closed this on Mar 17, 2020

   ---

8. DrahtBot locked this on Feb 15, 2022

Contributors
Sjors promag

Labels
Feature