test: Remove incorrect assumptions in validation_flush_tests #18181

1. 
   MarcoFalke commented at 4:13 PM on February 19, 2020: member

   The tests assume standard library internals that may not hold on all supported archs or when the code is instrumented for sanitizer or debug use cases

   Fixes #18111

2. MarcoFalke force-pushed on Feb 19, 2020
3. DrahtBot added the label Tests on Feb 19, 2020
4. MarcoFalke force-pushed on Feb 19, 2020
5. fanquake requested review from jamesob on Feb 19, 2020
6. 
   DrahtBot commented at 6:02 PM on February 19, 2020: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   No conflicts as of last run.

7. test: Tabs to spaces in all tests

   Spaces are used in all of the source code except in these two instances

   fa31eebfe9
8. test: Remove incorrect assumptions in validation_flush_tests faca8eff39
9. MarcoFalke force-pushed on Feb 19, 2020
10. 
    jamesob commented at 9:07 PM on February 19, 2020: member

    ACK https://github.com/bitcoin/bitcoin/pull/18181/commits/faca8eff39876cc8c0ee609a89bdcebc21976d47 pending passing tests

11. 
    MarcoFalke commented at 7:56 PM on February 20, 2020: member

    @laanwj You opened issue #18111 . Any chance you could take a look here?

12. 
    fjahr commented at 9:37 AM on February 22, 2020: member

    ACK faca8eff39876cc8c0ee609a89bdcebc21976d47

    Reviewed code, tests pass.

13. MarcoFalke merged this on Feb 22, 2020
14. MarcoFalke closed this on Feb 22, 2020

    ---

15. MarcoFalke deleted the branch on Feb 22, 2020
16. sidhujag referenced this in commit bb1a7056d9 on Feb 22, 2020
17. sidhujag referenced this in commit 957ea7a98a on Nov 10, 2020
18. Fabcien referenced this in commit 7680ec0096 on Jan 18, 2021
19. PastaPastaPasta referenced this in commit f3d97f2f7f on Oct 23, 2021
20. UdjinM6 referenced this in commit e66f5e4e70 on Oct 24, 2021
21. PastaPastaPasta referenced this in commit f0cc5955b6 on Nov 1, 2021
22. pravblockc referenced this in commit a9a9e00cce on Nov 18, 2021
23. DrahtBot locked this on Feb 15, 2022

Review Requested
jamesob