Non merge/review. PR will be deleted once appveyor job has run.
WIP: Touch appveyor vcpkg file to force refresh #18207
pull sipsorcery wants to merge 1 commits into bitcoin:master from sipsorcery:appveyor-force-refresh changing 1 files +1 −1-
sipsorcery commented at 12:03 PM on February 25, 2020: member
-
WIP: Touch appveyor vcpkg file to force refresh 45a723b348
-
sipsorcery commented at 12:17 PM on February 25, 2020: member
Do you think the current issue was triggered by my rebase of #15382, which adds
boost-process?Yes I suspect building your PR may have thrown a spanner in the works. Perhaps because the Bitcoin Core appveyor account allows two simultaneous jobs the dependency cache got corrupted somehow. It's normally just a matter of re-building the vcpkg package dependencies to fix which is what this PR should do.
-
Sjors commented at 12:43 PM on February 25, 2020: member
Should we make the cache machine specific (assuming there's an environment param to indicate which machine we're on)?
-
sipsorcery commented at 12:54 PM on February 25, 2020: member
My understanding is the cache is not stored on a per virtual machine basis. You specify a cache key (a directory path) and all instances of the job download the cache entry when they start.
I think the approach here is that we accept we'll have occasional issues with appveyor dependencies and deal with them on a case by case basis. They should be relatively rare particularly since we've pegged the vcpkg ports files to a specific commit ID.
-
DrahtBot commented at 1:01 PM on February 25, 2020: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #15382 (util: add runCommandParseJSON by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
sipsorcery commented at 1:22 PM on February 25, 2020: member
Appveyor working again,
- sipsorcery closed this on Feb 25, 2020
- DrahtBot locked this on Feb 15, 2022