wallet: Give slightly more understandable advice when needing -fallbackfee #18214

1. 
   instagibbs commented at 10:03 pm on February 27, 2020: member

   Current advice leads users like myself to add -fallbackfee alone which appears to do nothing.
2. Give slightly more understandable advise when needing -fallbackfee b387f3a303
3. fanquake added the label Wallet on Feb 27, 2020
4. MarcoFalke added the label Docs on Feb 27, 2020
5. MarcoFalke renamed this:
   Give slightly more understandable advice when needing -fallbackfee
   wallet: Give slightly more understandable advice when needing -fallbackfee
   on Feb 27, 2020
6. 
   DrahtBot commented at 11:22 pm on February 27, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17526 (Use Single Random Draw In addition to knapsack as coin selection fallback by achow101)
   • #17331 (Use effective values throughout coin selection by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. fanquake requested review from achow101 on Feb 28, 2020
8. in src/wallet/wallet.cpp:2803 in b387f3a303

   2799@@ -2800,7 +2800,7 @@ bool CWallet::CreateTransaction(interfaces::Chain::Lock& locked_chain, const std
   2800                 nFeeNeeded = GetMinimumFee(*this, nBytes, coin_control, &feeCalc);
   2801                 if (feeCalc.reason == FeeReason::FALLBACK && !m_allow_fallback_fee) {
   2802                     // eventually allow a fallback fee
   2803-                    strFailReason = _("Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee.").translated;
   2804+                    strFailReason = _("Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee=<BTC/kB>.").translated;
   

   ---

   ---

   

   MarcoFalke commented at 5:30 pm on February 28, 2020:

   Tend to NACK

   • The documentation (-help or -?) is already pretty clear on this being an amount and not a flag
   • This is a translation string, so all translations are invalided, for little reason. Also, it complicates translations
   • The underlying bug should be fixed. See #18225

   ---

   

   instagibbs commented at 5:22 pm on March 4, 2020:

   FWIW debug logs already do it:

   0src/qt/bitcoinstrings.cpp:137:QT_TRANSLATE_NOOP("bitcoin-core", "Invalid amount for -fallbackfee=<amount>: '%s'"),
   1src/wallet/wallet.cpp:3799:            error = strprintf(_("Invalid amount for -fallbackfee=<amount>: '%s'").translated, gArgs.GetArg("-fallbackfee", ""));
   

9. instagibbs closed this on Feb 28, 2020

   ---

10. fanquake referenced this in commit 9027960932 on Feb 29, 2020
11. sidhujag referenced this in commit 2885532fc0 on Feb 29, 2020
12. sidhujag referenced this in commit a2cbd0de22 on Nov 10, 2020
13. MarcoFalke locked this on Feb 15, 2022
14. Munkybooty referenced this in commit 46602c6207 on Nov 8, 2022
15. Munkybooty referenced this in commit 8538615a0f on Nov 15, 2022
16. Munkybooty referenced this in commit e9c55e8f16 on Nov 25, 2022
17. Munkybooty referenced this in commit 91c3cf3bc9 on Nov 25, 2022
18. Munkybooty referenced this in commit e7641109e5 on Dec 6, 2022
19. Munkybooty referenced this in commit ff14bdbcf4 on Dec 13, 2022
20. Munkybooty referenced this in commit 1fde7060cc on Dec 27, 2022

Contributors
instagibbs DrahtBot MarcoFalke

Review Requested
achow101

Labels
Docs Wallet