Test some transaction creation with non-empty fee estimator #18245

pull instagibbs wants to merge 3 commits into bitcoin:master from instagibbs:test_est_txn changing 2 files +38 −1

instagibbs commented at 6:15 PM on March 2, 2020: member

These tests give additional coverage to RPCs that use conf_target in a meaningful way that doesn't just return min rates.

Inspired by https://github.com/bitcoin/bitcoin/issues/18240
assert_fee_amount should round down f996ff8bbe
0 < conf_target < 1008 for RPC 64eca91294
Test that wallet is using correct conf_target feerates when prescribed 31bdc33baa
instagibbs commented at 6:18 PM on March 2, 2020: member

Probably a good idea to stick this test somewhere else, but that would require either replication of this test(filling out the estimator?) or refactoring it to use it as a library.
DrahtBot added the label Tests on Mar 2, 2020

instagibbs commented at 7:11 PM on March 2, 2020: member

one build failing:

    assert_fee_amount(tx2_info["fee"], tx2_info["vsize"], med_fee)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 39, in assert_fee_amount
    raise AssertionError("Fee of %s BTC too low! (Should be %s BTC)" % (str(fee), str(target_fee)))
AssertionError: Fee of 0.00008981 BTC too low! (Should be 0.00012702 BTC)

Will investigate

DrahtBot commented at 11:50 PM on March 20, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #13990 (Allow fee estimation to work with lower fees by ajtowns)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
instagibbs commented at 3:24 PM on August 10, 2020: member

not taking this further, someone else can pick it up
instagibbs closed this on Aug 10, 2020
jonatack commented at 4:52 PM on August 10, 2020: member

@instagibbs I wrote/am writing conf_target tests as part of follow-ups to #11413 and will look at pulling these commits in.
DrahtBot locked this on Feb 15, 2022
adamjonas added the label Up for grabs on Aug 2, 2022

Contributors

Labels

Linked (view graph)

#18240 bumpfee RPC not working as expected since 0.19.0.1

Test some transaction creation with non-empty fee estimator #18245

Conflicts