Ban spamnode #18277

konez2k commented at 1:38 PM on March 6, 2020: none

No description provided.

Merge #16415: Get rid of PendingWalletTx class

4d94916f0dda535cb69b538ee4e3fffb5b033c87 Get rid of PendingWalletTx class. (Russell Yanofsky)

Pull request description:

  No reason for this class to exist if it doesn't have any code to run in the destructor. e10e1e8db043e9b7c113e07faf408f337c1b732d from https://github.com/bitcoin/bitcoin/pull/16208 recently removed the destructor code that would return an unused key if the transaction wasn't committed.

  This is just cleanup, there's no change in behavior.

ACKs for top commit:
  ariard:
    utACK 4d94916. Successfully built both `bitcoind` and `bitcoin-qt`. `PendingWalletTx` was only a wrapper to enforce call to `ReturnDestination` if `CommitTransaction` doesn't `KeepDestination` before.
  promag:
    ACK 4d94916f0dda535cb69b538ee4e3fffb5b033c87, refactor looks good to me.
  meshcollider:
    utACK 4d94916f0dda535cb69b538ee4e3fffb5b033c87

Tree-SHA512: f3f93d2f2f5d8f1e7810d609d881c1b1cbbaa8629f483f4293e20b3210292605e947bc4903fde9d2d8736277ca3bd6de182f7eac1e13515d5a327f2ebc130839

aba63ebfbb

Merge #15588: Log the actual wallet file version and no longer publicly expose the "version" record

35e60e790f2cd602d1bdd0be835d27f0ba37efa9 Remove ReadVersion and WriteVersion (Andrew Chow)
b3d4f6c9619142948ab3d53551b4f3c0d7d73bde Log the actual wallet file version (Andrew Chow)
c88e87c3b2be3f97b712107e04285d06dfef3878 Remove nFileVersion from CWalletScanState (Andrew Chow)

Pull request description:

  The wallet file version is stored in the "minversion" record, not the "version" record. However "version" is no longer used anywhere except to record the highest versioned client which has opened a wallet file (which is currently only used to check whether this was most recently opened by a 0.4.0 or 0.5.0rc1 client which had a broken wallet encryption implementation). Furthermore, "version" was logged to the debug.log which is confusing because it is not the actual wallet file version.

  This PR changes it so that this confusion largely no longer exists. The wallet file version logging is changed to use "minversion" and reading and writing the "version" record is no longer publicly exposed to prevent potential confusion about whether the actual file version is being read or written. Lastly, in the one place it is actually used, the variable name is changed from nFileVersion to last_client to better reflect what that record actually represents.

ACKs for top commit:
  jb55:
    ACK 35e60e7, I compiled locally as a quick sanity check.
  ryanofsky:
    utACK 35e60e790f2cd602d1bdd0be835d27f0ba37efa9. This code still pretty confusing, but a little simpler now. And the previous log statement was really misleading and useless compared to the new one here.
  meshcollider:
    Looks good, thanks! utACK 35e60e790f2cd602d1bdd0be835d27f0ba37efa9

Tree-SHA512: f782b2f215d07fbc9b806322bda8085445b81c02b65ca674a8c6a3e1de505a0abd050669afe0ead4778816144a1c18462e13930071cedb7227a058aeb39493f7

dc8c17b962

remove seeds a4d3c7ce6a

update checkpoints and message start 9d75e67d30

remove seeds 89bdcb936f

update default port 975127f8f0

update gitignore 4d2736ba88

BitGreen rebrand 36e2b1fb36

update regtest ports 85209b236f

update estimated blockchain size 5459967c63

update base58 prefixes 7d8874c070

[branding] Update ticker 35ae169a35

Update gitignore a51a5cbafc

Add proof of stake f7508753b8

Update client name cfb46b4349

package: update pixmaps ebd41a5e21

build: fix custom_dsstore 8afb60e6fe

[gui] Update various icons (bitcoin -> bitgreen) 00901c754d

[gui] Add global stylesheet; Add icons/images ca4df2eb28

[gui] Fix overview page artifacts 71413ba590

[gui] New icons; Disable platform icon-coloring 90c65ad137

[gui] Fix HelpMessageDialog layout cc46cf84e2

Add Dash Core and Bitcoin Core to CopyrightHolders() ca8d772a8f

[gui] Rearrange menus 0e2a0d13d8

[gui] Improve visibility of buttons f42e6afdf6

Add "immer" functional/immutable library f52aba10a7

Use C++14 standard when building 9314acc731

Add BLS libraries, wrappers, helpers and benchmarks e575ea8f15

Update build system 7a1fd2a906

Update unit tests 541571eef5

Update PoS b352517299

Update mining mainnet minimum work 5e45245fd8

Add serialization for bitsets, lists and tuples f8561c57cb

Implement std::unordered_map/set compatible hasher classes for salted hashes

Allows convenient salted hashing with unordered maps and sets. Useful when
there is a risk of unbalanced hash buckets slowing things down, e.g. when
externally supplied hashes are used as keys into a map.

d7c9ae0994

Implement hasher and signer for ProTx transactions 9af0784929

Implement unordered_lru_cache b736837774

Implement transaction type and extra payload 0137521324

Implement CDBTransactionIterator d0a433f988

Prepare and update logging 1c55911852

Add cxxtimer eb68409fbe

Implement LLMQ protocol messages 82f3ae3422

Implement protocol MNLIST messages 87d4e1474e

Implement GetAddressInfo in CAddrMan 7a0e7fca5b

Implement ProTx, LLMQ, net processing, RPC 89c54abfce

Disable cbTx checks before tx version 2 ff6af58cc1

lower PoW end and reset min chain work 5bbd9bc6bb

Add masternode logging 0a7da420c0

mining using version 1 till PoW end block 12824b0e40

Change NULL to nullptr e74e285ed1

code cleanup 2e4226ca25

Check tx merkle root only on PoS phase d83f3db01a

[init] Start / Stop LLMQ 0927807973

Introduce masternode payments bbc1b3f799

[net] command management 9917ae4b21

Update transaction checks 5e88ffc014

Update gitignore ee5ba76ec8

[protx] manage both register and register_fund transactions 4857ee4489

Initial masternode rpc 48274fd202

Register masternode commands b9e80eb5c9

fix deadlocks d3ed6f5306

[protx] fix help on rpc 24a97f4aac

[masternode] update connection check 50edcb59fc

[protx] update version and collateral 68add69acb

[masternode] Check block payee/value 3dd32971a1

[masternode] check block payee only during PoS phase b67f205a3f

fix log message b2e4821cde

[masternode] Fix transaction vout for PoS 5437f3eccc

[masternode] Disable superblocks 6a0aa7fa43

[llmq] enable quorum commitment 9e33578f37

Set PoS min split threshold c2c3362138

[rpc] impleement protx list/info d374ac603d

[rpc] implement protx list/info ec0ee47513

[PoS] update default transaction type 29acb29876

[PoS] create a custom type for PoS txes c78f473036

add missing endline bbf2f5bd98

[masternode] test payment on PoS tx 72495f56b8

[masternode] fill payments using the minted block height d680b74564

update transactions checks 548b84bca9

[net] return if protocol extension is found 8091c05a6d

[miner] restart checks in case of exceptions ae1ec017b6

[RPC] add mnsync 7e12c563e9

[wallet] fix potential deadlock 92ed0f4251

[wallet] change chain lock 954527ad22

set chain LLMQ params 94a2e420d4

rollback ae1ec01 and wait

masternode sync

0ea0aa6b80

remove invalid param b218b76147

[rpc] show qcTx on transaction 6bfc4fcc24

add missing blockheader vchBlockSig 0d9bfe4333

set LLMQ activation height 392ea9a7a2

[masternode] disable payments till last PoW block 415b121786

set quorum activation height e2951f6444

check quorum commitment transaction a9672a25e2

check quorum commitment on mempool e44fdb478b

[rpc] add quorum actions 4ade921ae1

set segwit as always active 6ca86a2213

change llmq quorum for testing a39ec9ad98

[miner] write always scriptPubKey to coinbase b5ad7b8540

misc issue resolution

   . set powLimit correctly for testnet to avoid segfault
   . correct compilation issue for quorum debug

3e222fa2b7

implement dash network layer

    . merge bitcoin/dash netstack and inventory commandset
    . implement minimal sporkset and associated rpc handlers
    . implement block rollback/reprocessing functions

1b60398f0a

Include nFlags on CBlockIndex fa44a053af

Merge pull request #4 from barrystyle/develop

dash masternode utilities

729276ec05

refactor mapMultiArgs to gArgs.GetArgs 77abd1fbb8

Loading/dump fulfilled requests cache 5bdd89e744

load sporks cache ba27845722

Add sporkaddr and minsporkkey help 96d4713ab4

refactor spork strMessageMagic ec297f3855

Honor filterInventoryKnown for non-tx/non-block items cdb117559d

[spork] remove deterministic mns b7c46dfd7c

[spork] disable if running in lite mode 127cbcf19f

rollback unordered_map serialization 9f58d7331b

[spork] use g_connman 502a2e82c8

[rcp] fix spork value 238218d1e9

[spork] log cleanup b2688441f6

[protocol] refactor ppszTypeName / IsKnownType f1c53a0e59

[net] implement DataDownloadState

This is a copy of TxDownloadState to manage custom inv/getdata

d9bcadff0e

[net] refactor EraseInvRequest to remove the request on all nodes 3cc2b566ac

Implement SPORK_3_QUORUM_DKG_ENABLED 9f5933e143

Implement SPORK_4_CHAINLOCKS_ENABLED 80b08a1ae5

Update quorum dkgstatus help 157cbfea4b

add dip0003 masternode tab to ui 7863f6a99a

Merge pull request #5 from barrystyle/masternodeui

DIP0003 masternode tab

99aafab856

Set appropriate minrelaytxfee. 4a772057f0

Merge pull request #7 from bitgreen/fix-minrelaytxfee

Set appropriate minrelaytxfee.

1a313221ad

Remove IsCoinStake() from maturity check. 93337ed7fe

Merge pull request #8 from barrystyle/prevent-maturity-assert

Remove IsCoinStake() from maturity check.

ae99d03c01

add missing newline 803847f87d

add additional debug to activemasternode e10ef561c2

[init] add watchquorums 40673a19d6

[rpc] fix quorum help 7e6d45c1b8

[miner] Upgrade version on LLMQ activation 4cc5481c6f

[rpc] cast size_t to uint64_t 24880b2283

Update configure to reject unsafe miniUPnPc API ver

Also fixes behavior when libminiupnpc is not installed.

43171ab995

net: Drop support of the insecure miniUPnPc versions a0ee82f9ad

[qt] add missing masternodes icon ab83e06641

Fix macos qt bin 7bfb9927eb

Implement SyncTransaction signals 595cde8c8e

Implement AcceptedBlockHeader signals b144570bcb

Split CDBWrapper Read / ReadDataStream a222e899e6

Move base governance fileset to track changes. 1625fc3801

add instasend logging 26bbf6a68a

prepare instantsend sporks 71817a89a7

Merge branch 'master' into new_codebase_ui_improvements f6d6ad07e9

Merge pull request #1 from bluepp2/new_codebase_ui_improvements

New codebase ui improvements

3559426d9e

Add my masternode option and allow different ports. c756293007

Merge pull request #11 from bitgreen/mymn-tab

Add my masternode option and allow different ports.

8e69d7a2ef

Disable RBF by default. 6d4ec15e5f

Update to suit new codebase as required. 55e2cb5e4c

[net] refactor RequestData b132b937fe

[net] remove unused code 9714fab630

[net] check min protocol version for RelayInv 5f10f08e02

prepare chainparams llmq instantsend params 5fd96f30b0

prepare instantsend options category 1a710f608b

[log] Update instantsend log flag and crease size 30954a38bb

update instantsend sporks 1bc213f153

implement InstantSend c14c2f7682

[zmq] add instant send support 0c0db00426

[rpc] add instantsend support c790a6bcb1

[qt] add instantsend support 0ab61bfbc1

update spork example 4c6fa1270f

rollback CReserveKey (replaced by ReserveDestination) aec4b58012

refactor IsDIP3Enforced a72278e7f6

rollback rpc utils 3ba309ae82

missing reserveKey refactor cc79a06c35

rollback PendingWalletTx and reintroduce ChainLockReceived signal 9c37a8288a

change AvailableCoinsType 2702b1b482

implement IsPayToPublicKeyHash 647d10f720

remove unused methods fa3cabe7fc

code cleanup c2b628a896

refactor RequestData / RemoveDataRequest b4f64ca3be

remove unused variable e8ce1fc782

remove unused variable 9755b210a9

update governance chainparams 7344dae9d4

fix RemoveDataRequest 310e936841

remove duplicated params 992444094f

Merge pull request #10 from bitgreen/governance

Add governance system

3ad23ca9b1

Merge branch 'master' into instantx fd1500c133

Merge pull request #12 from bitgreen/instantx

Instantx

94c2fdffb6

remove duplicated declaration 34086516de

add superblock spork 8f3947e55a

add governance payments d28b4212fe

update information window label order 5dbbbe2083

update chainparams budget activation efa0fed254

[rpc] register governance methods 54793d8496

fix deadlock issue 27dc6c83c5

add missing mnsync asset name c7117b7405

fix transaction list columns 19d6b3389e

fix lock issue 5c1774a4d8

[masternode] support multiple ports 0c4b61fce1

update build number 049b91625e

add msising qt include 990fff269d

Add masternode outputs and listunspent filter c4bd371419

update pos/masternode/governance payment check 0968c11d69

update budget start block 5759115fc1

update build version e55842b9ca

update protocol version 76a8e19492

set min peer proto version a5a3cdcba1

remove debug info, initialize var ab5f90dac8

refactor sporks 1d3744db05

update budget block reward 6e65976c61

update release build 724fcff4b9

[rpc] getblockstats: exclude coinstake transactions d7d54a2e5f

fix add to block index chainlock 13645601a8

update budget payment start block d36a220869

update build number 5062533a24

[Qt] filter masternode rewards 37ae6ab4b2

reset masternode bls keys on shutdown de2c04b81a

[Qt] fix my masternode filter e34b1ea251

[Qt] update toolbar icons f7914aebd6

update chain rewards 96c0af925c

update chain params 1d6bb9d126

remove var redeclaration b0571fc9a4

update readme 99c6fdfc76

prepare release 365600e20b

final chain params 5af9cd8085

fix deterministic masternode list 31044cbec4

update version 487696a2ac

added seed nodes 4d26e13bea

add checkpoint e9e9bdcca9

Add governance tab. e03fd026d1

Merge pull request #14 from bitgreen/ui-overhaul

Add governance tab

6f9c6a18fd

mark pos blocks properly 0ab550ebb4

if a protx tx did not have enough fee, give this as a failure reason 62bb2a5433

tweak ReacceptWalletTransactions() to deal with orphaned stakes 60e1702d07

update version for client debugging purposes 3cec6575ff

Merge pull request #15 from bitgreen/corruptionissue

Recent wallet issues

bcaba640a9

log: add masternode category e5da99fa33

makefile: add governance icon 052904b328

Alternate method for testing proof-of-stake validity. d596ed2c3c

Merge branch 'pos-abuse' 0e00f632a8

Display the chain sync progress bar. abe5235a72

Merge branch 'chainprogressdisplay' 2d9df30d2b

hardened stake checks enforced at block 67500 bfbd36522e

Merge pull request #16 from bitgreen/prevent-unfair-stakes

hardened stake checks enforced at block 67500

fb3114c8f1

enable quorum signing b6bbbc41ac

Merge pull request #17 from bitgreen/enable-quorum-signing

enable quorum signing

c40279a37c

Bumped fork block to 70000 aa5797de8b

add chainlocks via spork 6 765d4a886b

bump build version d3ad701aa3

Merge #14593: gui: explicitly disable "Dark Mode" appearance on macOS

cf2f4306fe26305b24bba8833af845ada3a42ec8 gui: explicitly disable "Dark Mode" appearance on macOS (fanquake)

Pull request description:

  Bitcoin Core's gui is pretty broken for a someone using macOS in "Dark Mode"; the biggest issue being lots of white text on a white background, leaving most inputs, the rpc console etc unusable.

  This is likely something we'll have to wait for Qt to fix/support, so it's probably easiest to just disable for now, rather than provide a broken UI; see screenshots below. This issue might not have come up much yet, given the issues with the 0.17.0 dmg.

  Apple documentation on "Opting out of Dark Mode" is [here](https://developer.apple.com/documentation/appkit/nsappearancecustomization/choosing_a_specific_appearance_for_your_app).
  > If you need extra time to work on your app's Dark Mode support, you can temporarily opt out by including the NSRequiresAquaSystemAppearance key (with a value of true) in your app’s Info.plist file. Setting this key to true causes the system to ignore the user's preference and always apply a light appearance to your app.

  Related upstream tickets:
  * [Qt Applications are not usable under macOS Mojave with dark theme](https://bugreports.qt.io/browse/QTBUG-68850)
  * [macOS 10.14 Mojave Support](https://bugreports.qt.io/browse/QTBUG-68891)

  Screenshots:
  ![main](https://user-images.githubusercontent.com/863730/47616668-f8769400-dafa-11e8-9ec5-9f184d8210f8.png)
  ![pay to](https://user-images.githubusercontent.com/863730/47616670-fad8ee00-dafa-11e8-876f-c656de0e31c4.png)
  ![qr code - not hilighted](https://user-images.githubusercontent.com/863730/47616671-fdd3de80-dafa-11e8-873f-f7fa3e91c2a0.png)
  ![qr code](https://user-images.githubusercontent.com/863730/47616672-00363880-dafb-11e8-883c-59a084b18120.png)

Tree-SHA512: 01f6f6b1fed0f20937b433adef38ff55ccacce8b4405dd6be67356ee9a470a56b8e511cc79909a39c3091a852f444284e49a8773cf6c037a29669804185ca92d

02635ce3ee

rollback 02635ce3 1e63463e34

Remove possibility of stake being accepted more than once. 40ddc26a93

Merge pull request #18 from bitgreen/dup-hashproof

Remove possibility of stake being accepted more than once.

2083327f81

Merge pull request #18 from bitgreen/dup-hashproof

Remove possibility of stake being accepted more than once.

473f9caedb

Merge branch 'master' of https://github.com/bitgreen/bitgreen 32b5da00ca

update release 6518a0036f

Prevent staking where inappropriate. 6a0dd9c048

Get a trigger from ProcessNewBlock to where it can ban in net_processing.cpp 5833fa24de

reduce logging 89db6f39ef

update tests 2692c388ae

ban misbehaving nodes fe3ebc7736

konez2k closed this on Mar 6, 2020

konez2k deleted the branch on Mar 6, 2020

fanquake locked this on Mar 6, 2020