Add an explicit regression test for the condvar bug (#18227), so that this doesn't happen again
test: Check that wait_until returns if time point is in the past #18285
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2002-debugBoost changing 1 files +18 −0-
MarcoFalke commented at 9:10 PM on March 6, 2020: member
-
test: Check that wait_until returns if time point is in the past fab7d14ea5
-
laanwj commented at 9:40 PM on March 6, 2020: member
In the case where this doesn't hold, this test would wait forever, correct?
-
MarcoFalke commented at 9:48 PM on March 6, 2020: member
I can't say what happens if this doesn't hold. Boost for example would throw an exception and thus crash the program.
- fanquake added the label Tests on Mar 6, 2020
-
laanwj commented at 3:11 PM on March 11, 2020: member
ACK fab7d14ea5a4305317d66f35beb3225a07823d42 Despite fail-behavior being unpredictable, having a test is much better than not having one.
- laanwj merged this on Mar 11, 2020
- laanwj closed this on Mar 11, 2020
- MarcoFalke deleted the branch on Mar 11, 2020
- sidhujag referenced this in commit d9eaa09aea on Mar 11, 2020
- deadalnix referenced this in commit b23802b869 on Jun 29, 2020
- sidhujag referenced this in commit a15661f3b5 on Nov 10, 2020
- PastaPastaPasta referenced this in commit 16feb0bf56 on Jun 27, 2021
- PastaPastaPasta referenced this in commit cdf7274255 on Jun 28, 2021
- PastaPastaPasta referenced this in commit 07813b5bce on Jun 29, 2021
- PastaPastaPasta referenced this in commit 7b9dbad9c2 on Jul 1, 2021
- PastaPastaPasta referenced this in commit b6d94d9a67 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 2f6f313942 on Jul 14, 2021
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels