fix some double-spaces in strings #1830

Diapolo commented at 4:31 PM on September 18, 2012: none

remove some unneeded stuff in sendcoinsentry.ui
harmonize some "Error:"-messages

in src/qt/sendcoinsdialog.cpp:None in 397a527c1e outdated

 147 | @@ -148,7 +148,7 @@ void SendCoinsDialog::on_sendButton_clicked()
 148 |          break;
 149 |      case WalletModel::TransactionCreationFailed:
 150 |          QMessageBox::warning(this, tr("Send Coins"),
 151 | -            tr("Error: Transaction creation failed."),
 152 | +            tr("Error: Transaction creation failed!"),

luke-jr commented at 7:23 AM on September 19, 2012:

I don't really care that much, but why the punctuation change? Just makes more work for the translators IMO.

laanwj commented at 7:52 AM on September 19, 2012:

I tend to agree.

The cost of changing messages is n * m, where n is the number of changed messages and m the number of translations. Please handle accordingly.

Fixing messages for significant imrpovements in clarity and user-friendlyless is good, but please stop this "fixing spaces".

Luke-jr cleaned up the mess (lost translations) last time, but I can understand that he gets annoyed.

Diapolo commented at 8:50 AM on September 19, 2012:

If all who contribute translatable strings to the source would be a little more straight there would be no need for this. It really annoys me, that we have strings that have incorrect grammar or punctuation.

At least for the string "Error: Transaction creation failed." we currently already have 2 strings in the translations, this pull makes one out of them.

You are free to close such pulls you consider not valuable, even if I don't agree here, as a good overall string handling was needed badly and this covers the last things I could find!

laanwj commented at 9:38 AM on September 19, 2012:

I agree that more consistent punctuation is nice.

What we really need to make this kind of changes feasible is a script that takes the old and new English message and updates all the translations on Transifex.

BitcoinPullTester commented at 5:21 PM on September 19, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/397a527c1e9c334564668e18e48d875d29eca787 for binaries and test log.

sipa commented at 2:09 PM on October 7, 2012: member

ACK for 0.8

BitcoinPullTester commented at 5:32 AM on October 21, 2012: none

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/b38fd5d5a4e4babec207dda033a5c95ada29047b for binaries and test log.

This could happen for one of several reasons:

It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
It does not build on either Linux i386 or Win32 (via MinGW cross compile)
The test suite fails on either Linux i386 or Win32
The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

fix some double-spaces in strings

- remove some unneeded stuff in sendcoinsentry.ui
- harmonize some "Error:"-messages

6b3783a9c9

in src/init.cpp:None in b38fd5d5a4 outdated

 447 | @@ -448,7 +448,7 @@ bool AppInit2()
 448 |      if (file) fclose(file);
 449 |      static boost::interprocess::file_lock lock(pathLockFile.string().c_str());
 450 |      if (!lock.try_lock())
 451 | -        return InitError(strprintf(_("Cannot obtain a lock on data directory %s.  Bitcoin is probably already running."), strDataDir.c_str()));
 452 | +        return InitError(strprintf(_("Cannot obtain a lock on data directory %s. Bitcoin is probably already running."), strDataDir));

laanwj commented at 7:00 AM on October 21, 2012:

You cut off a .c_str() here

Diapolo commented at 8:41 PM on October 21, 2012:

Fixed, thanks for noticing.

BitcoinPullTester commented at 8:18 PM on October 31, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/6b3783a9c9cc47afcf72aa0a86ea26122392efdb for binaries and test log.

Diapolo commented at 7:15 AM on November 5, 2012: none

IMHO the time to do such a pull is NOW, as we have much time left for translators catching up. If this pull is considered useless (which at least sipa doesn't think ^^) just close it.

laanwj referenced this in commit 86406daeca on Nov 5, 2012

laanwj merged this on Nov 5, 2012

laanwj closed this on Nov 5, 2012

laudney referenced this in commit 36e146b95f on Mar 19, 2014

KolbyML referenced this in commit a9946da47d on Dec 5, 2020

KolbyML referenced this in commit d7bb310f0c on Dec 5, 2020

KolbyML referenced this in commit 4136d8f5a6 on Dec 5, 2020

DrahtBot locked this on Sep 8, 2021