Bumpfee test fix #18311

pull instagibbs wants to merge 2 commits into bitcoin:master from instagibbs:bumpfee_test_fix changing 1 files +62 −46
  1. instagibbs commented at 4:58 PM on March 10, 2020: member

    In the loop we accidentally used origfee which is not the value to check, and also allowed the loop to exit too early since the new fee must be strictly greater than 0.0005.

    Also converted/added a bunch of logging from comments.

    Resolves https://github.com/bitcoin/bitcoin/issues/17716

  2. in test/functional/wallet_bumpfee.py:455 in efe1bb87b3 outdated 
     452 |  
 453 | -def test_change_script_match(rbf_node, dest_address):
 454 | -    """Test that the same change addresses is used for the replacement transaction when possible."""
 455 | +def test_change_script_match(self, rbf_node, dest_address):
 456 | +    self.log.info('Test that the same change addresses is used for the replacement transaction when possible.')
 457 |      def get_change_address(tx):
    MarcoFalke commented at 5:44 PM on March 10, 2020: 
    test/functional/wallet_bumpfee.py:454:5: E306 expected 1 blank line before a nested definition, found 0
    instagibbs commented at 5:59 PM on March 10, 2020:

    fixed, linter passing, merge please

  3. Add some test logging to wallet_bumpfee.py 2e4edc68f9
  4. bumpfee test: exit loop at proper time with new fee value being compared f1b4503114
  5. instagibbs force-pushed on Mar 10, 2020
  6. DrahtBot added the label Tests on Mar 10, 2020
  7. MarcoFalke commented at 6:14 PM on March 10, 2020: member

    ACK f1b45031148105754c23af08c891387e71c3c2c3 🏈

    <details><summary>Show signature and timestamp</summary>

    Signature:

    -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK f1b45031148105754c23af08c891387e71c3c2c3 🏈
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUgGvgwAkvzXwCDsArn/R/cQCKAPKFPl+GNz3gekt+dd27h8GPs/94lQJcFZXynQ
yetDewQNZD/jsX/Hcqm7L6SHTRF5tCAwalUxinhtppMkI1s+/WHZhkL4a2P7H/Ly
IE0j1cVwfMunbTkghFGe9d6x2kb8Spm0HUnNrPrB0CMExy/Ck+SymRpsSLprhZ93
FLbmbwcWWHoF5fydwlZpecz7h/Bi/UJB1v20YQZBSD3PXG3HnvnmRpeCM4PyM0Yw
gQNI75ms7HadiccyLpDVGJto2kSuj+WNSDV/wICKEMBxPflBjMvOEMG/BulC39V7
Pf2hvOPRUTeUxPi93ziKkd2SMDyb0UGErsJ56msUW5NBTci1EvGDUDXe8jHk9JND
BYzD5TnlKYgeT2A0YhGRHfPMjoUTtzONz85OwZKkWkF/GBUD+qFvLh9oChysuCP+
r0Zh46JtDCO3qaXFhCkuRpbGcRyY4YC6FJ9fkJV+oAjO1+5chwjGqcJNLJ8Rcir5
xGiNHth5
=hXEx
-----END PGP SIGNATURE-----

    Timestamp of file with hash 2cb7f2f63d873829e88b88ecaf04dec4dacf7f4a5dff0034c9a41405f4ffb2b5 -

    </details>

  8. MarcoFalke merged this on Mar 10, 2020
  9. MarcoFalke closed this on Mar 10, 2020
  10. jonatack commented at 6:45 PM on March 10, 2020: member

    ACK efe1bb8

  11. jonatack commented at 6:46 PM on March 10, 2020: member

    GitHub caches so aggressively, I didn't see this had been updated and then merged :man_shrugging:

  12. DrahtBot locked this on Feb 15, 2022
Contributors
instagibbsMarcoFalkejonatack
Labels
Tests
Linked (view graph)
#17716 intermittent functional test failure in wallet_bumpfee
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me