Use min relay value constant in QT #18343

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:qt_min_relay changing 1 files +2 −1

instagibbs commented at 1:55 PM on March 13, 2020: member

No description provided.
Use min relay value constant in QT effa8730b6
luke-jr commented at 1:57 PM on March 13, 2020: member

I guess it's a strict improvement, but shouldn't it be using the user-configured value??
instagibbs commented at 2:04 PM on March 13, 2020: member

@luke-jr this value is the one that "rejects" too-low values, aka something that simply cannot propogate. Once a user picks a rate(above that) it sticks to it.

(although I guess this can change too depending on current mempool minfee, eh?)
fanquake added the label GUI on Mar 13, 2020

in src/qt/sendcoinsdialog.cpp:179 in effa8730b6

 175 | @@ -175,7 +176,7 @@ void SendCoinsDialog::setModel(WalletModel *_model)
 176 |          connect(ui->customFee, &BitcoinAmountField::valueChanged, this, &SendCoinsDialog::coinControlUpdateLabels);
 177 |          connect(ui->optInRBF, &QCheckBox::stateChanged, this, &SendCoinsDialog::updateSmartFeeLabel);
 178 |          connect(ui->optInRBF, &QCheckBox::stateChanged, this, &SendCoinsDialog::coinControlUpdateLabels);
 179 | -        CAmount requiredFee = model->wallet().getRequiredFee(1000);
 180 | +        CAmount requiredFee = model->wallet().getRequiredFee(DEFAULT_MIN_RELAY_TX_FEE);

MarcoFalke commented at 2:52 PM on March 13, 2020:

Huh? The units don't match up here. 1000 is of unit kB and the constant you put in here is a feerate.

MarcoFalke changes_requested
MarcoFalke commented at 2:53 PM on March 13, 2020: member

NACK, not sure what this is trying to solve
instagibbs commented at 3:10 PM on March 13, 2020: member

hmm I thought I tested this locally but this is obviously wrong, closing
instagibbs closed this on Mar 13, 2020
luke-jr commented at 11:06 PM on April 22, 2020: member

aka something that simply cannot propogate

Literally anything CAN propagate.

Network policies are not constants, and should assume to vary.
instagibbs commented at 11:53 PM on April 22, 2020: member

Not sure why you're necroing this PR.

On Wed, Apr 22, 2020, 7:06 PM Luke Dashjr notifications@github.com wrote:

aka something that simply cannot propogate

Literally anything CAN propagate.

Network policies are not constants, and should assume to vary.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/18343#issuecomment-618084458, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMAFU6CLJC4LDRJPEJCVLDRN5Z7NANCNFSM4LHC7AFQ .
DrahtBot locked this on Feb 15, 2022

Contributors

Labels