Built 0.19.1 from source, get the warning "This is a pre-release..." developers forgot to remove it. #18355

<!-- This issue tracker is only for technical issues related to Bitcoin Core. General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com. For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/. If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->

<!-- Describe the issue -->

Expected behavior

<!--- What behavior did you expect? -->

Actual behavior

<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->

To reproduce

<!--- How reliably can you reproduce the issue, what are the steps to do so? -->

System information

<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->

<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->

<!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->

<!-- Any extra information that might be useful in the debugging process. -->

<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->

Subject says it all

See commit 58ba7c314d552cea8cb024960a8504577aee586f, which says define(_CLIENT_VERSION_IS_RELEASE, true) on the tangent line.

What commit are you compiling exactly?

I downloaded the master tree from github. The link from bitcoin.org indicated it was the new release of 0.19.1. Someone should tell the appropriate person at bitcoin.org to link to the commit instead of the master tree. When I grep CLIENT_VERSION_IS_RELEASE, it is set to false. Latest commit d402c1e 5 hours ago I see now that a few patches have been added since 58ba7c3 I'm not using the wallet so I'll go ahead and use the daemon I compiled. I'm running 3 of them to support the network at each of the locations where we have network service.

If you want the 0.19.1 release, you need the v0.19.1 tag. The master branch is where work is proceeding for the upcoming 0.20.0 release which is indeed not released yet .

git checkout v0.19.1