doc: Comment fix merkle.cpp #18379

pull redwrasse wants to merge 1 commits into bitcoin:master from redwrasse:4d55397500-patch-1-1 changing 1 files +1 −1
  1. redwrasse commented at 5:36 PM on March 18, 2020: none

    Change comment from The reason is that if the number of hashes in the list at a given time is odd, to The reason is that if the number of hashes in the list at a given level is odd (to be a bit more precise: replacing time with level)

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. Update merkle.cpp
    Change comment from `The reason is that if the number of hashes in the list at a given time
    is odd`, to ` The reason is that if the number of hashes in the list at a given level
           is odd` (to be a bit more precise)
    5b59a19731
  3. sipa commented at 5:40 PM on March 18, 2020: member

    ACK

  4. MarcoFalke renamed this:
    Comment fix merkle.cpp
    doc: Comment fix merkle.cpp
    on Mar 18, 2020
  5. MarcoFalke commented at 5:54 PM on March 18, 2020: member

    ACK 5b59a19731827398aa32754d1f327178247d3199

  6. MarcoFalke merged this on Mar 18, 2020
  7. MarcoFalke closed this on Mar 18, 2020

  8. fanquake added the label Docs on Mar 18, 2020
  9. redwrasse deleted the branch on Mar 18, 2020
  10. redwrasse restored the branch on Mar 18, 2020
  11. redwrasse deleted the branch on Mar 18, 2020
  12. redwrasse restored the branch on Mar 18, 2020
  13. MarkLTZ referenced this in commit 8823f65197 on Apr 7, 2020
  14. MarkLTZ referenced this in commit 0a1571d657 on Apr 7, 2020
  15. Fabcien referenced this in commit bed7d6c42d on Jan 9, 2021
  16. PastaPastaPasta referenced this in commit 136f6647e3 on Jun 27, 2021
  17. PastaPastaPasta referenced this in commit 3674c42c75 on Jun 28, 2021
  18. PastaPastaPasta referenced this in commit e5fc86f061 on Jun 29, 2021
  19. PastaPastaPasta referenced this in commit 2b1c957bd0 on Jul 1, 2021
  20. PastaPastaPasta referenced this in commit 2affc94333 on Jul 1, 2021
  21. PastaPastaPasta referenced this in commit 88e9b10ac1 on Jul 14, 2021
  22. PastaPastaPasta referenced this in commit c3a80793d1 on Jul 14, 2021
  23. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me