Editing address book labels sometimes duplicates entry #1839

issue dooglus opened this issue on September 19, 2012
  1. dooglus commented at 6:00 PM on September 19, 2012: contributor

    Here's a section of my address book:

    before

    I edit the label on the "lessthan 1" entry:

    edit

    And then it shows up twice:

    after

    Restarting bitcoin-qt fixes it so it only shows up once again.

    I tried reproducing this with a new wallet with an empty address book, but couldn't.

    I built against the v0.7.0 label in git. The logfile claims I'm running: Bitcoin version v0.7.0rc3-dirty-beta (2012-09-12 14:07:22 -0400)

    I expect rc3 is the same as the final release.

  2. laanwj commented at 3:53 AM on September 20, 2012: member

    Can you paste the relevant part of the debug.log?

    Especially stuff such as:

    NotifyAddressBookChanged ...
    

    And warnings like:

    Warning: AddressTablePriv::updateEntry
    
  3. dooglus commented at 5:15 AM on September 20, 2012: contributor

    Sure (I renamed 'satoshidice lessthan 48000' by adding an 'x' to the end of its label):

    FIXME: handle dialog start. 
    NotifyAddressBookChanged 1dice9wcMu5hLF4g81u8nioL5mmSHTApw satoshidice lessthan 48000x isMine=0 status=1
    NotifyAddressBookChanged 1dice9wcMu5hLF4g81u8nioL5mmSHTApw  isMine=0 status=2
    NotifyAddressBookChanged 1dice9wcMu5hLF4g81u8nioL5mmSHTApw satoshidice lessthan 48000x isMine=0 status=0
    FIXME: handle dialog end. 
    Warning: AddressTablePriv::updateEntry: Got CT_UPDATED, but entry is not in model
    Warning: AddressTablePriv::updateEntry: Got CT_DELETED, but entry is not in model
    Flushing wallet.dat
    Flushed wallet.dat 258ms
    
  4. ghost assigned laanwj on Sep 25, 2012
  5. jambolo commented at 6:11 PM on November 4, 2012: none

    I also have this problem. It happens on both receive coins and address book lists. In the receive coins list case, a new address is generated for the duplicate. That is a serious problem.

    My log looks the same as the one above.

    Bitcoin version v0.7.0-beta (2012-09-12 14:07:22 -0400)

  6. nybble41 commented at 7:09 PM on December 1, 2012: none

    I can confirm that this problem is still occurring with bitcoin-qt version v0.7.1.0-geb49457-beta, at least for the "Receive coins" list. I also noticed that the list does not get updated when the labels are changed via an RPC command.

  7. Diapolo commented at 1:14 PM on January 9, 2013: none

    @dooglus @jambolo Can you test the fix from #2157? You find a Windows binary for that pull over here: http://jenkins.bluematt.me/pull-tester/e6d230056202b05a27f187dff2648eb5c76fcfee/bitcoin/bitcoin-qt.exe

    Others are also encouraged to test the fix! @nybble41 I also noticed that the list does not get updated when the labels are changed via an RPC command. It would be nice to know if this one is still present and if yes can you create a separate issue please :).

  8. dooglus commented at 7:15 AM on January 11, 2013: contributor

    I don't use Windows, but I built a Linux binary from #2157 and it does indeed appear to fix this issue.

    As for @nybble41's comment, I've tried using the RPC command setaccount on the same address with various different account names using the #2157 build, and it updates correctly in the 'receive coins' tab each time.

  9. Diapolo commented at 7:17 AM on January 11, 2013: none

    @dooglus Thanks for testing, that are some good news :).

  10. Diapolo commented at 3:03 PM on January 28, 2013: none

    @laanwj Can be closed!

  11. laanwj closed this on Jan 28, 2013

  12. underdarkskies referenced this in commit 599a771bcf on Jul 3, 2018
  13. underdarkskies referenced this in commit 7066de9651 on Jul 3, 2018
  14. underdarkskies referenced this in commit 9648c47e6a on Jul 6, 2018
  15. underdarkskies referenced this in commit 5fe2283289 on Jul 6, 2018
  16. underdarkskies referenced this in commit a387f968cf on Jul 6, 2018
  17. underdarkskies referenced this in commit 1715ece29b on Jul 7, 2018
  18. underdarkskies referenced this in commit b9622224ee on Jul 7, 2018
  19. underdarkskies referenced this in commit 7d36d40e1c on Jul 7, 2018
  20. underdarkskies referenced this in commit 4cecaa019c on Jul 10, 2018
  21. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 00:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me