gui: Import only required Objective-C headers #18400

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20200321-objc-headers changing 3 files +11 −10

hebasto commented at 8:07 PM on March 21, 2020: member

AppKit/AppKit.h, Cocoa/Cocoa.h and Foundation/Foundation.h are just bundles of other headers.

With this PR only required headers are imported.
Import only required Objective-C headers 9d274cb7e3
DrahtBot added the label GUI on Mar 21, 2020
fanquake added the label macOS on Mar 21, 2020
MarcoFalke renamed this:
~~Import only required Objective-C headers~~
gui: Import only required Objective-C headers
on Mar 22, 2020
laanwj commented at 4:44 PM on March 25, 2020: member

~0 on this, maybe this is better out of principle, but I don't think headers included in one file significantly affect compile time or memory use.
promag commented at 11:41 AM on April 10, 2020: member

Agree with @laanwj, the less platform specific code the better, and the savings aren't worth.
hebasto closed this on Apr 10, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels