45771671704f0ed09aec48777c12f0af388d1beb (#1077) moved build.h to a build directory, but if src/build.h exists from previous builds, it is preferred over the new file.
src/build.h preferred over build/build.h #1841
issue luke-jr opened this issue on September 20, 2012-
luke-jr commented at 11:02 AM on September 20, 2012: member
-
laanwj commented at 11:43 AM on September 20, 2012: member
Solution: just remove the old build.h file
-
sipa commented at 12:38 PM on September 20, 2012: member
The qt builds use build/build.h, the bitcoind builds use obj/build.h. Nothing uses src/build.h anymore, so you can just remove that.
-
luke-jr commented at 1:15 PM on September 20, 2012: member
Yes, that is a workaround. It doesn't fix the problem, however, which still lurks quietly for anyone who doesn't know to delete it...
-
sipa commented at 1:24 PM on September 20, 2012: member
I'm not sure we should prevent all possible effects of unclean build directories.
-
luke-jr commented at 1:50 PM on September 20, 2012: member
It's not as if "make clean" deals with this either. OTOH, maybe it makes sense to prefer a src/build.h for other reasons, history aside.
-
gavinandresen commented at 2:16 PM on September 20, 2012: contributor
I see two bugs:
make clean should remove obj/build.h
.gitignore should not ignore src/build.h, so 'git status' shows the obsolete src/version.h.
I'll push a fix for those.
I agree with @sipa, time moves forward and we don't want to muddy our source or Makefiles for stuff we changed in the past.
-
gavinandresen commented at 2:30 PM on September 20, 2012: contributor
Fixes to .gitignore and make clean pushed, I'm going to close this.
- gavinandresen closed this on Sep 20, 2012
-
luke-jr commented at 7:47 PM on September 20, 2012: member
@gavinandresen Sounds reasonable.
- DrahtBot locked this on Sep 8, 2021
Contributors