Add test for whitelisted peers' transactions when -blocksonly mode is on #18428

issue glowang opened this issue on March 25, 2020
  1. glowang commented at 6:19 AM on March 25, 2020: contributor

    <!-- This issue tracker is only for technical issues related to Bitcoin Core. General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com. For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/. If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->

    <!-- Describe the issue -->

    <!--- What behavior did you expect? -->

    <!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->

    <!--- How reliably can you reproduce the issue, what are the steps to do so? -->

    <!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->

    <!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->

    <!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->

    <!-- Any extra information that might be useful in the debugging process. -->

    <!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->

    In #18391 we fixed the documentation issue for -blocksonly and how it interacts with other parameters. We would to extend the test in p2p_blocksonly.py for wallet transactions and maybe even whitelisted peers, to ensure that our understanding of the behavior is correct and our update in 18391 is accurate.

  2. MarcoFalke added the label Tests on Mar 29, 2020
  3. glowang commented at 12:19 PM on March 29, 2020: contributor

    I would like to work on this issue, as a continuation of the work in the 18391 PR.

  4. MarcoFalke referenced this in commit cfe22a5f9e on May 21, 2020
  5. sidhujag referenced this in commit 8c3da42ad5 on May 21, 2020
  6. MarcoFalke commented at 10:11 AM on March 18, 2021: member

    Fixed #18530

  7. MarcoFalke closed this on Mar 18, 2021

  8. PastaPastaPasta referenced this in commit 4d6f0cd2f2 on Jun 29, 2022
  9. DrahtBot locked this on Aug 18, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-03 18:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me