test: Remove unsafe BOOST_TEST_MESSAGE #18472

1. 
   MarcoFalke commented at 5:54 pm on March 30, 2020: member

   Fixes #17987

   Can be tested with

   0./src/test/test_bitcoin -l test_suite  -- DEBUG_LOG_OUT
   

2. 
   MarcoFalke commented at 5:55 pm on March 30, 2020: member

   cc @mzumsande
3. MarcoFalke added this to the milestone 0.20.0 on Mar 30, 2020
4. DrahtBot added the label Build system on Mar 30, 2020
5. DrahtBot added the label Tests on Mar 30, 2020
6. 
   DrahtBot commented at 6:33 pm on March 30, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18000 (Index for UTXO Set Statistics by fjahr)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. test: Remove unsafe BOOST_TEST_MESSAGE fa3cc0bfc4
8. MarcoFalke force-pushed on Mar 30, 2020
9. MarcoFalke removed the label Build system on Mar 30, 2020
10. 
    fjahr commented at 8:50 pm on March 30, 2020: member

    tested ACK fa3cc0bfc4c4fc13a384fc291403c9fd41082f18

    Thank you!

11. 
    mzumsande commented at 6:24 pm on March 31, 2020: member

    Tested ACK fa3cc0bfc4c4fc13a384fc291403c9fd41082f18

    Maybe test/README.md could mention the DEBUG_LOG_OUT option which I find really helpful, and possibly also a warning that BOOST_TEST_MESSAGE, which is mentioned there, is not threadsafe.

12. 
    MarcoFalke commented at 7:39 pm on March 31, 2020: member

    Thanks, I am going to go ahead and merge this bug fix. Will update the docs in a new commit.
13. MarcoFalke merged this on Mar 31, 2020
14. MarcoFalke closed this on Mar 31, 2020

    ---

15. MarcoFalke deleted the branch on Mar 31, 2020
16. 
    MarcoFalke commented at 8:34 pm on March 31, 2020: member

    Done here: #18486
17. sidhujag referenced this in commit 2462660fc6 on Mar 31, 2020
18. MarcoFalke referenced this in commit eb773f1063 on Apr 1, 2020
19. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke DrahtBot fjahr mzumsande

Labels
Tests

Milestone
0.20.0