Without a connection there is no way to sync, so we can fail early and don't have to wait for the timeout
test: check that peer is connected when calling sync_* #18474
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2003-qaCheckConnSync changing 1 files +6 −0-
MarcoFalke commented at 7:55 PM on March 30, 2020: member
-
test: check that peer is connected when calling sync_* fac3716b09
- DrahtBot added the label Tests on Mar 30, 2020
-
jonatack commented at 8:33 PM on March 31, 2020: member
ACK fac3716b09bb9
Ran the p2p tests twice compared to master and they don't appear to be slowed down by this change -- they actually ran a few seconds faster.
- MarcoFalke merged this on Mar 31, 2020
- MarcoFalke closed this on Mar 31, 2020
- sidhujag referenced this in commit 2e6eaa2098 on Mar 31, 2020
- MarcoFalke deleted the branch on Apr 1, 2020
- random-zebra referenced this in commit 6bc917e859 on Jul 6, 2020
- Fabcien referenced this in commit a05e018b95 on Jan 13, 2021
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels