test: Check that calling walletpasshprase does not freeze the node #18507

1. 
   MarcoFalke commented at 3:16 pm on April 2, 2020: member
2. MarcoFalke added this to the milestone 0.20.0 on Apr 2, 2020
3. in test/functional/wallet_encryption.py:45 in fa8e523730 outdated

   39@@ -38,6 +40,12 @@ def run_test(self):
   40         assert_raises_rpc_error(-8, "passphrase can not be empty", self.nodes[0].encryptwallet, '')
   41         self.nodes[0].encryptwallet(passphrase)
   42 
   43+        for i in range(5):
   44+            r = random.uniform(0.9, 1.1)
   45+            self.log.info('Check that calling walletpasshprase does not freeze the node. sleep={}'.format(r))
   

   ---

   ---

   

   jonatack commented at 3:56 pm on April 2, 2020:

   s/walletpasshprase/walletpassphrase/
4. 
   jonatack commented at 3:58 pm on April 2, 2020: member

   Good idea. Currently timing out after 60 seconds but I suppose this is for testing #18487.
5. 
   jonatack commented at 4:07 pm on April 2, 2020: member

   This passes on #18487, but am seeing another error about 20% of the time:

   02020-04-02T16:05:38.667000Z TestFramework (ERROR): Assertion failed
   1Traceback (most recent call last):
   2  File "/home/jon/projects/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 112, in main
   3    self.run_test()
   4  File "test/functional/wallet_encryption.py", line 131, in run_test
   5    assert_raises_rpc_error(-13, "Please enter the wallet passphrase with walletpassphrase first", self.nodes[0].dumpprivkey, address)
   6  File "/home/jon/projects/bitcoin/bitcoin/test/functional/test_framework/util.py", line 114, in assert_raises_rpc_error
   7    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
   8AssertionError: No exception raised
   

6. test: Check that calling walletpasshprase does not freeze the node faae3f9adf
7. MarcoFalke force-pushed on Apr 2, 2020
8. 
   promag commented at 4:32 pm on April 2, 2020: member

   I don’t think this would always fail without #18487 so it doesn’t prevent a regression. Maybe we should unit test that RPCRunLater waits for event callback to finish if the call was already triggered?
9. MarcoFalke removed this from the milestone 0.20.0 on Apr 2, 2020
10. DrahtBot added the label Tests on Apr 2, 2020
11. MarcoFalke closed this on Apr 6, 2020

    ---

12. MarcoFalke deleted the branch on Apr 6, 2020
13. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke jonatack promag

Labels
Tests