test: Check that calling walletpasshprase does not freeze the node #18507

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2004-qaWalletFreeze changing 1 files +10 −0

MarcoFalke commented at 3:16 PM on April 2, 2020: member

No description provided.
MarcoFalke added this to the milestone 0.20.0 on Apr 2, 2020

in test/functional/wallet_encryption.py:45 in fa8e523730 outdated

  39 | @@ -38,6 +40,12 @@ def run_test(self):
  40 |          assert_raises_rpc_error(-8, "passphrase can not be empty", self.nodes[0].encryptwallet, '')
  41 |          self.nodes[0].encryptwallet(passphrase)
  42 |  
  43 | +        for i in range(5):
  44 | +            r = random.uniform(0.9, 1.1)
  45 | +            self.log.info('Check that calling walletpasshprase does not freeze the node. sleep={}'.format(r))

jonatack commented at 3:56 PM on April 2, 2020:

s/walletpasshprase/walletpassphrase/

jonatack commented at 3:58 PM on April 2, 2020: member

Good idea. Currently timing out after 60 seconds but I suppose this is for testing #18487.

jonatack commented at 4:07 PM on April 2, 2020: member

This passes on #18487, but am seeing another error about 20% of the time:

2020-04-02T16:05:38.667000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/jon/projects/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 112, in main
    self.run_test()
  File "test/functional/wallet_encryption.py", line 131, in run_test
    assert_raises_rpc_error(-13, "Please enter the wallet passphrase with walletpassphrase first", self.nodes[0].dumpprivkey, address)
  File "/home/jon/projects/bitcoin/bitcoin/test/functional/test_framework/util.py", line 114, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
AssertionError: No exception raised

test: Check that calling walletpasshprase does not freeze the node faae3f9adf
MarcoFalke force-pushed on Apr 2, 2020
promag commented at 4:32 PM on April 2, 2020: member

I don't think this would always fail without #18487 so it doesn't prevent a regression. Maybe we should unit test that RPCRunLater waits for event callback to finish if the call was already triggered?
MarcoFalke removed this from the milestone 0.20.0 on Apr 2, 2020
DrahtBot added the label Tests on Apr 2, 2020
MarcoFalke closed this on Apr 6, 2020
MarcoFalke deleted the branch on Apr 6, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels