Remove PID file at the very end #18526

1. 
   hebasto commented at 7:58 pm on April 4, 2020: member

   While reproducing the bug from #18517, I’ve noticed that the bitcoind.pid file has already been removed when the bitcoind hangs.

   This PR makes Shutdown() keep the bitcoind.pid file available until the end.

2. 
   DrahtBot commented at 1:23 am on April 5, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18189 (Add error handling to all boost filesystem functions by uhliksk)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. in src/init.cpp:288 in b2486a3493 outdated

   285@@ -293,6 +286,14 @@ void Shutdown(NodeContext& node)
   286     if (node.mempool) node.mempool = nullptr;
   287     node.scheduler.reset();
   288     LogPrintf("%s: done\n", __func__);
   

   ---

   ---

   

   emilengler commented at 12:20 pm on April 6, 2020:

   I would put line 288 at the very end. Done should always be the last message in a log. Otherwise it would be weird if stuff still follows

   ---

   

   hebasto commented at 2:19 pm on April 6, 2020:

   Done.
4. emilengler changes_requested
5. 
   emilengler commented at 12:21 pm on April 6, 2020: contributor

   Concept ACK with exception to move the done LogPrintf
6. Remove PID file at the very end 7fcdec0f32
7. hebasto force-pushed on Apr 6, 2020
8. 
   hebasto commented at 2:18 pm on April 6, 2020: member

   Updated b2486a3493516745a452b5b87e44289dfb55fed3 -> 7fcdec0f326f7fb547ec9c651871842cf518ea38 (pr18526.01 -> pr18526.02, diff):

   • addressed @emilengler ’s comment

   I would put line 288 at the very end. Done should always be the last message in a log. Otherwise it would be weird if stuff still follows

9. emilengler approved
10. 
    emilengler commented at 2:20 pm on April 6, 2020: contributor

    utACK 7fcdec0f326f7fb547ec9c651871842cf518ea38
11. 
    MarcoFalke commented at 3:05 pm on April 6, 2020: member

    ACK 7fcdec0f326f7fb547ec9c651871842cf518ea38
12. 
    promag commented at 10:46 pm on April 9, 2020: member

    Code review ACK 7fcdec0f326f7fb547ec9c651871842cf518ea38.
13. theStack approved
14. 
    theStack commented at 2:20 pm on April 10, 2020: member

    Code review ACK 7fcdec0f326f7fb547ec9c651871842cf518ea38
15. MarcoFalke merged this on Apr 10, 2020
16. MarcoFalke closed this on Apr 10, 2020

    ---

17. hebasto deleted the branch on Apr 10, 2020
18. sidhujag referenced this in commit 91b634cd18 on Apr 13, 2020
19. Fabcien referenced this in commit 3393b70184 on Jan 14, 2021
20. DrahtBot locked this on Feb 15, 2022

Contributors
hebasto DrahtBot emilengler MarcoFalke promag theStack